chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java - Issue 2964233003: Revert of Allow choosing target language in more languages menu(translate infobar)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java

Issue 2964233003: Revert of Allow choosing target language in more languages menu(translate infobar) (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java

index 21a032f70dc2218818e557a1ab4c193ece0e623b..1dc3f014e3602bc77470b23606ee8104b89b0845 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java

@@ -411,12 +411,6 @@

@Override

public void onSourceMenuItemClicked(String code) {

- // If source language is same as target language, the infobar will dismiss and no

- // translation will be done.

- if (mOptions.targetLanguageCode().equals(code)) {

- closeInfobar(true);

- return;

- }

// Reset source code in both UI and native.

if (mNativeTranslateInfoBarPtr != 0 && mOptions.setSourceLanguage(code)) {

recordInfobarLanguageData(

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java » ('j') | no next file with comments »