Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: ios/chrome/browser/ui/bubble/bubble_view_controller.mm

Issue 2964233002: [ios] BubbleViewController and BubbleView stubs. (Closed)
Patch Set: Fix enum style, comments, and label attributes Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/bubble/bubble_view_controller.mm
diff --git a/ios/chrome/browser/ui/bubble/bubble_view_controller.mm b/ios/chrome/browser/ui/bubble/bubble_view_controller.mm
new file mode 100644
index 0000000000000000000000000000000000000000..59b63090a31f9322ba1ca4155dc182545a9150ce
--- /dev/null
+++ b/ios/chrome/browser/ui/bubble/bubble_view_controller.mm
@@ -0,0 +1,33 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import "ios/chrome/browser/ui/bubble/bubble_view_controller.h"
+
+#include "base/logging.h"
+
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
+@implementation BubbleViewController
+
+- (instancetype)initWithText:(NSString*)text
+ direction:(BubbleArrowDirection)arrowDirection
+ alignment:(BubbleAlignment)alignment {
+ self = [super initWithNibName:nil bundle:nil];
+ self.view = [[BubbleView alloc] initWithText:text
rohitrao (ping after 24h) 2017/07/10 17:44:28 Should this assignment be in loadView instead?
edchin 2017/07/10 17:51:59 Yes, you're right. We probably would have caught t
helenlyang 2017/07/10 18:21:28 Fixed. In order to initialize BubbleView in loadVi
+ direction:arrowDirection
+ alignment:alignment];
+ return self;
+}
+
+- (void)animateContentIn {
+ NOTIMPLEMENTED();
+}
+
+- (void)dismissAnimated:(BOOL)animated {
+ NOTIMPLEMENTED();
+}
+
+@end
« no previous file with comments | « ios/chrome/browser/ui/bubble/bubble_view_controller.h ('k') | ios/chrome/browser/ui/bubble/bubble_view_controller_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698