Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 // Copyright 2017 The Chromium Authors. All rights reserved. | |
| 2 // Use of this source code is governed by a BSD-style license that can be | |
| 3 // found in the LICENSE file. | |
| 4 | |
| 5 #import "ios/chrome/browser/ui/bubble/bubble_view_controller.h" | |
| 6 | |
| 7 #include "base/logging.h" | |
| 8 | |
| 9 #if !defined(__has_feature) || !__has_feature(objc_arc) | |
| 10 #error "This file requires ARC support." | |
| 11 #endif | |
| 12 | |
| 13 @implementation BubbleViewController | |
| 14 | |
| 15 - (instancetype)initWithText:(NSString*)text | |
| 16 direction:(BubbleArrowDirection)arrowDirection | |
| 17 alignment:(BubbleAlignment)alignment { | |
| 18 self = [super initWithNibName:nil bundle:nil]; | |
| 19 self.view = [[BubbleView alloc] initWithText:text | |
|
rohitrao (ping after 24h)
2017/07/10 17:44:28
Should this assignment be in loadView instead?
edchin
2017/07/10 17:51:59
Yes, you're right. We probably would have caught t
helenlyang
2017/07/10 18:21:28
Fixed. In order to initialize BubbleView in loadVi
| |
| 20 direction:arrowDirection | |
| 21 alignment:alignment]; | |
| 22 return self; | |
| 23 } | |
| 24 | |
| 25 - (void)animateContentIn { | |
| 26 NOTIMPLEMENTED(); | |
| 27 } | |
| 28 | |
| 29 - (void)dismissAnimated:(BOOL)animated { | |
| 30 NOTIMPLEMENTED(); | |
| 31 } | |
| 32 | |
| 33 @end | |
| OLD | NEW |