Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2964213003: [Payment Request] Create billing address directly from credit card editor (Closed)

Created:
3 years, 5 months ago by Moe
Modified:
3 years, 5 months ago
Reviewers:
rayraymond, macourteau
CC:
chromium-reviews, gogerald+paymentswatch_chromium.org, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, mahmadi+paymentsioswatch_chromium.org, mahmadi+paymentswatch_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payment Request] Create billing address directly from credit card editor User should be able to create a billing address directly from the credit card editor if there are no billing addresses to choose from. https://drive.google.com/file/d/0B-GXJsF3pXyjN2pFWldOMlhMTVE/view?usp=sharing BUG=602666 Review-Url: https://codereview.chromium.org/2964213003 Cr-Commit-Position: refs/heads/master@{#484099} Committed: https://chromium.googlesource.com/chromium/src/+/da011c94bf6f1f8b75970518b4223f2251e26825

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -12 lines) Patch
M ios/chrome/browser/ui/payments/credit_card_edit_coordinator.h View 2 chunks +5 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/payments/credit_card_edit_coordinator.mm View 5 chunks +43 lines, -9 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Moe
Hi Randy, Please take a look.
3 years, 5 months ago (2017-06-30 22:09:23 UTC) #2
rayraymond
On 2017/06/30 22:09:23, Moe wrote: > Hi Randy, Please take a look. This is cool ...
3 years, 5 months ago (2017-06-30 22:20:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2964213003/1
3 years, 5 months ago (2017-06-30 22:21:09 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 5 months ago (2017-06-30 22:21:10 UTC) #9
Moe
Hi Mac, I forgot about the whole committer thing. Randy's LGTM's no good. Could you ...
3 years, 5 months ago (2017-06-30 22:23:29 UTC) #11
macourteau
lgtm
3 years, 5 months ago (2017-07-03 17:44:08 UTC) #12
Moe
On 2017/07/03 at 17:44:08, macourteau wrote: > lgtm Thank you.
3 years, 5 months ago (2017-07-04 13:39:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2964213003/1
3 years, 5 months ago (2017-07-04 13:39:31 UTC) #15
commit-bot: I haz the power
3 years, 5 months ago (2017-07-04 13:56:20 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/da011c94bf6f1f8b75970518b422...

Powered by Google App Engine
This is Rietveld 408576698