Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2964163002: Revert of Fix for URL opening code (Closed)

Created:
3 years, 5 months ago by dominicc (has gone to gerrit)
Modified:
3 years, 4 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix for URL opening code (patchset #18 id:340001 of https://codereview.chromium.org/2798143004/ ) Reason for revert: Reverting this per the comments on crbug.com/735958 Original issue's description: > Fix for tab opening code > > When URL is opened from other program or local file system and session restored at the same time, opened URL is shown in a window behind restore session and not really visible to user. > > This fixes opening URL for cases: > 1. When Chromium is not started yet. > 2. When Chromium is started, has window(s). > 3. When chromium app is started, but has no windows. > > for different startup settings: > 1. Default startup. > 2. Restore session on startup. > 3. Open pre-defined set of URLs on startup. > > > > R=sky@chromium.org,gab@chromium.org,avi@chromium.org > > BUG=708873 > > Review-Url: https://codereview.chromium.org/2798143004 > Cr-Commit-Position: refs/heads/master@{#479684} > Committed: https://chromium.googlesource.com/chromium/src/+/7afbc36eeee75f34c8ad3aa2f90cb6fc1f345463 TBR=avi@chromium.org,gab@chromium.org,sky@chromium.org,eugenebng@yandex-team.ru # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=708873

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -457 lines) Patch
M chrome/browser/app_controller_mac.mm View 3 chunks +13 lines, -44 lines 0 comments Download
M chrome/browser/app_controller_mac_browsertest.mm View 6 chunks +7 lines, -205 lines 0 comments Download
M chrome/browser/lifetime/browser_close_manager_browsertest.cc View 45 chunks +78 lines, -44 lines 0 comments Download
M chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc View 2 chunks +1 line, -14 lines 0 comments Download
M chrome/browser/sessions/session_restore.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/sessions/session_restore.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/sessions/session_restore_browsertest.cc View 3 chunks +0 lines, -49 lines 0 comments Download
D content/public/test/repeated_notification_observer.h View 1 chunk +0 lines, -39 lines 0 comments Download
D content/public/test/repeated_notification_observer.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dominicc (has gone to gerrit)
Created Revert of Fix for URL opening code
3 years, 5 months ago (2017-06-30 00:56:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2964163002/1
3 years, 5 months ago (2017-06-30 00:57:13 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/249192)
3 years, 5 months ago (2017-06-30 00:59:59 UTC) #5
gab
On 2017/06/30 00:59:59, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 5 months ago (2017-07-12 04:30:05 UTC) #6
sky
3 years, 5 months ago (2017-07-12 15:45:43 UTC) #7
On 2017/07/12 04:30:05, gab (in-out til july17) wrote:
> On 2017/06/30 00:59:59, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
> 
> Status? Close?

I'm trying to revert the same patch here:
https://chromium-review.googlesource.com/c/567562/ . So, ya, I recommend closing
this one out.

Powered by Google App Engine
This is Rietveld 408576698