Add a Finch feature and runtime flag for multidevice.

Add a Finch feature and runtime flag for multidevice.

BUG=718617
Review-Url: https://codereview.chromium.org/2964153002
Cr-Commit-Position: refs/heads/master@{#483827}
Committed: https://chromium.googlesource.com/chromium/src/+/21da031c60b78c7360fdcb80f755772492ef67cb

[Oren Blasberg, 2017-06-30 02:03:52]

orenb@chromium.org changed reviewers:
+ thestig@chromium.org

[Oren Blasberg, 2017-06-30 02:07:19]

Description was changed from

==========
Add a Finch feature and runtime flag for multidevice.

BUG=718617
==========

to

==========
Add a Finch feature and runtime flag for multidevice.

BUG=718617
==========

[Oren Blasberg, 2017-06-30 02:07:19]

orenb@chromium.org changed reviewers:
+ hansberry@chromium.org

[Oren Blasberg, 2017-06-30 02:07:26]

Thanks for the review!

[Lei Zhang, 2017-06-30 03:30:46]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-30 03:30:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2017-06-30 03:31:01]

lgtm

[commit-bot: I haz the power, 2017-06-30 03:45:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-30 03:45:03]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Lei Zhang, 2017-06-30 04:08:03]

https://codereview.chromium.org/2964153002/diff/20001/chrome/common/chrome_fe...
File chrome/common/chrome_features.cc (right):

https://codereview.chromium.org/2964153002/diff/20001/chrome/common/chrome_fe...
chrome/common/chrome_features.cc:255: // Enables or disables multidevice
features and corresponding UI on Chrome OS.
Missing #if guards.

[Oren Blasberg, 2017-06-30 15:10:36]

https://codereview.chromium.org/2964153002/diff/20001/chrome/common/chrome_fe...
File chrome/common/chrome_features.cc (right):

https://codereview.chromium.org/2964153002/diff/20001/chrome/common/chrome_fe...
chrome/common/chrome_features.cc:255: // Enables or disables multidevice
features and corresponding UI on Chrome OS.
On 2017/06/30 04:08:02, Lei Zhang wrote:
> Missing #if guards.

Done, thanks for catching that!

[Oren Blasberg, 2017-06-30 15:10:45]

The CQ bit was checked by orenb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-30 15:11:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 16:21:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-30 16:21:20]

Dry run: This issue passed the CQ dry run.

[Oren Blasberg, 2017-06-30 20:56:10]

The CQ bit was checked by orenb@chromium.org

[Oren Blasberg, 2017-06-30 20:56:10]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2964153002/#ps40001
(title: "If guards")

[commit-bot: I haz the power, 2017-06-30 20:56:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 21:24:22]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498856170181660,
"parent_rev": "e65e2d1acb3c3bb037f0183bdd3db4cf35da45c2", "commit_rev":
"21da031c60b78c7360fdcb80f755772492ef67cb"}

[commit-bot: I haz the power, 2017-06-30 21:24:38]

Description was changed from

==========
Add a Finch feature and runtime flag for multidevice.

BUG=718617
==========

to

==========
Add a Finch feature and runtime flag for multidevice.

BUG=718617

Review-Url: https://codereview.chromium.org/2964153002
Cr-Commit-Position: refs/heads/master@{#483827}
Committed:
https://chromium.googlesource.com/chromium/src/+/21da031c60b78c7360fdcb80f755...
==========

[commit-bot: I haz the power, 2017-06-30 21:24:40]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/21da031c60b78c7360fdcb80f755...