Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2964153002: Add a Finch feature and runtime flag for multidevice. (Closed)

Created:
3 years, 5 months ago by Oren Blasberg
Modified:
3 years, 5 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, shihuis_chromium.org, Jeremy Klein, James Hawkins, John Heroy
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a Finch feature and runtime flag for multidevice. BUG=718617 Review-Url: https://codereview.chromium.org/2964153002 Cr-Commit-Position: refs/heads/master@{#483827} Committed: https://chromium.googlesource.com/chromium/src/+/21da031c60b78c7360fdcb80f755772492ef67cb

Patch Set 1 #

Patch Set 2 : Add histogram enum #

Total comments: 2

Patch Set 3 : If guards #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M chrome/browser/about_flags.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/chrome_features.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/chrome_features.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
Oren Blasberg
3 years, 5 months ago (2017-06-30 02:03:53 UTC) #2
Oren Blasberg
Thanks for the review!
3 years, 5 months ago (2017-06-30 02:07:26 UTC) #5
Lei Zhang
lgtm
3 years, 5 months ago (2017-06-30 03:31:01 UTC) #8
Lei Zhang
https://codereview.chromium.org/2964153002/diff/20001/chrome/common/chrome_features.cc File chrome/common/chrome_features.cc (right): https://codereview.chromium.org/2964153002/diff/20001/chrome/common/chrome_features.cc#newcode255 chrome/common/chrome_features.cc:255: // Enables or disables multidevice features and corresponding UI ...
3 years, 5 months ago (2017-06-30 04:08:03 UTC) #11
Oren Blasberg
https://codereview.chromium.org/2964153002/diff/20001/chrome/common/chrome_features.cc File chrome/common/chrome_features.cc (right): https://codereview.chromium.org/2964153002/diff/20001/chrome/common/chrome_features.cc#newcode255 chrome/common/chrome_features.cc:255: // Enables or disables multidevice features and corresponding UI ...
3 years, 5 months ago (2017-06-30 15:10:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2964153002/40001
3 years, 5 months ago (2017-06-30 20:56:27 UTC) #19
commit-bot: I haz the power
3 years, 5 months ago (2017-06-30 21:24:40 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/21da031c60b78c7360fdcb80f755...

Powered by Google App Engine
This is Rietveld 408576698