Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn.py

Issue 2964133002: Exclude Observatory assets from PRODUCT build dart, dart_precompiled_runtime (Closed)
Patch Set: Addressed comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/tcmalloc/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn.py
diff --git a/tools/gn.py b/tools/gn.py
index 9b7fe2f96d5a9fdbdbbdd52604bb2a4c6dbfc8bd..5ac0bc97666301c2ca0629c8ec52eb85541212a7 100755
--- a/tools/gn.py
+++ b/tools/gn.py
@@ -189,7 +189,10 @@ def ToGnArgs(args, mode, arch, target_os):
# This setting is only meaningful for Flutter. Standalone builds of the VM
# should leave this set to 'develop', which causes the build to defer to
# 'is_debug', 'is_release' and 'is_product'.
- gn_args['dart_runtime_mode'] = 'develop'
+ if mode == 'product':
+ gn_args['dart_runtime_mode'] = 'release'
+ else:
+ gn_args['dart_runtime_mode'] = 'develop'
dont_use_clang = DontUseClang(args, gn_args['target_os'],
gn_args['host_cpu'],
« no previous file with comments | « third_party/tcmalloc/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698