Issue 296413008: [NaCl SDK] Temporarily disable SocketTestTCP.Listen test under PNaCl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 296413008: [NaCl SDK] Temporarily disable SocketTestTCP.Listen test under PNaCl (Closed)

Created:
6 years, 7 months ago by Sam Clegg

Modified:
6 years, 7 months ago

Reviewers:
binji

CC:
chromium-reviews, binji+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[NaCl SDK] Temporarily disable SocketTestTCP.Listen test under PNaCl R=binji@chromium.org, binji BUG=377084 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273004

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc	View		1 chunk	+9 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

binji

ok, lgtm. You can also disable in test_projects.py, but this works too

6 years, 7 months ago (2014-05-27 18:43:50 UTC) #2

Sam Clegg

6 years, 7 months ago (2014-05-27 19:05:53 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r273004 (presubmit successful).