Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc

Issue 296413008: [NaCl SDK] Temporarily disable SocketTestTCP.Listen test under PNaCl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc
diff --git a/native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc b/native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc
index c8e45b1404bddb840341ffdf2ef956614e1e943e..1954605371a125f173a9f48911a358528ab0bfdb 100644
--- a/native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc
+++ b/native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc
@@ -584,7 +584,15 @@ TEST_F(SocketTestUDP, Listen) {
EXPECT_EQ(errno, ENOTSUP);
}
-TEST_F(SocketTestTCP, Listen) {
+// Temporarily disable the TCP Listen test on PNaCl;
+// TODO(sbc): Re-enable once we fix the issue: http://crbug/377084
+#ifdef __pnacl__
+#define MAYBE_Listen DISABLED_Listen
+#else
+#define MAYBE_Listen Listen
+#endif
+
+TEST_F(SocketTestTCP, MAYBE_Listen) {
sockaddr_in addr;
socklen_t addrlen = sizeof(addr);
const char* client_greeting = "hello";
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698