LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/textbox-not-removed-crash.html - Issue 296413007: [New Multicolumn] Add support for column-span:all

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/textbox-not-removed-crash.html

Issue 296413007: [New Multicolumn] Add support for column-span:all (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@359976

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/table-multi-column-crash-expected.txt ('k') | LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/textbox-not-removed-crash-expected.txt » ('j') | LayoutTests/fast/multicol/span/adjacent-spanners.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/textbox-not-removed-crash.html

diff --git a/LayoutTests/fast/multicol/span/textbox-not-removed-crash.html b/LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/textbox-not-removed-crash.html

similarity index 65%

copy from LayoutTests/fast/multicol/span/textbox-not-removed-crash.html

copy to LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/textbox-not-removed-crash.html

index 42d40d1eb8a4394d4812439dff50e5991d817889..5639d51f257d564bb8d519d5dce164e6c8f41b8f 100644

--- a/LayoutTests/fast/multicol/span/textbox-not-removed-crash.html

+++ b/LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/textbox-not-removed-crash.html

@@ -1,6 +1,10 @@

<!DOCTYPE html>

<html>

<head>

+ <script>

+ if (window.internals)

+ internals.settings.setRegionBasedColumnsEnabled(true);

+ </script>

<style>

#test1 {

text-indent: -1em;

@@ -16,15 +20,15 @@ if (window.testRunner)

testRunner.dumpAsText();

function crash() {

- test1 = document.createElement('div');

- test1.setAttribute('id', 'test1');

+ test1 = document.createElement('div');

+ test1.setAttribute('id', 'test1');

document.body.appendChild(test1);

- test2 = document.createElement('div');

+ test2 = document.createElement('div');

test1.appendChild(test2);

- test3 = document.createElement('div');

+ test3 = document.createElement('div');

test3.setAttribute('id', 'test3');

test2.appendChild(test3);

- test2.appendChild(document.createTextNode('A'));

+ test2.appendChild(document.createTextNode('A'));

test2.style.display = '-webkit-box';

document.body.offsetTop;

test3.style.display = 'list-item';