LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/textbox-not-removed-crash.html - Issue 296413007: [New Multicolumn] Add support for column-span:all

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/textbox-not-removed-crash.html

Issue 296413007: [New Multicolumn] Add support for column-span:all (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@359976

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/table-multi-column-crash-expected.txt ('k') | LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/textbox-not-removed-crash-expected.txt » ('j') | LayoutTests/fast/multicol/span/adjacent-spanners.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

	4 <script>

	5 if (window.internals)

	6 internals.settings.setRegionBasedColumnsEnabled(true);

	7 </script>

4 <style>	8 <style>

5 #test1 {	9 #test1 {

6 text-indent: -1em;	10 text-indent: -1em;

7 content: counter(c);	11 content: counter(c);

8 -webkit-column-count: 1;	12 -webkit-column-count: 1;

9 }	13 }

10 #test3 {	14 #test3 {

11 -webkit-column-span: all;	15 -webkit-column-span: all;

12 }	16 }

13 </style>	17 </style>

14 <script>	18 <script>

15 if (window.testRunner)	19 if (window.testRunner)

16 testRunner.dumpAsText();	20 testRunner.dumpAsText();

17	21

18 function crash() {	22 function crash() {

19 test1 = document.createElement('div');	23 test1 = document.createElement('div');

20 test1.setAttribute('id', 'test1');	24 test1.setAttribute('id', 'test1');

21 document.body.appendChild(test1);	25 document.body.appendChild(test1);

22 test2 = document.createElement('div');	26 test2 = document.createElement('div');

23 test1.appendChild(test2);	27 test1.appendChild(test2);

24 test3 = document.createElement('div');	28 test3 = document.createElement('div');

25 test3.setAttribute('id', 'test3');	29 test3.setAttribute('id', 'test3');

26 test2.appendChild(test3);	30 test2.appendChild(test3);

27 test2.appendChild(document.createTextNode('A'));	31 test2.appendChild(document.createTextNode('A'));

28 test2.style.display = '-webkit-box';	32 test2.style.display = '-webkit-box';

29 document.body.offsetTop;	33 document.body.offsetTop;

30 test3.style.display = 'list-item';	34 test3.style.display = 'list-item';

31 document.body.offsetTop;	35 document.body.offsetTop;

32 document.body.style.zoom = 2;	36 document.body.style.zoom = 2;

33 }	37 }

34 window.onload = crash;	38 window.onload = crash;

35 </script>	39 </script>

36 </head>	40 </head>

37 <body>	41 <body>

38 Test passes if it does not crash.	42 Test passes if it does not crash.

39 </body>	43 </body>

40 </html>	44 </html>

OLD	NEW