LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/split-inline-wrong-post-block-crash.html - Issue 296413007: [New Multicolumn] Add support for column-span:all

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/split-inline-wrong-post-block-crash.html

Issue 296413007: [New Multicolumn] Add support for column-span:all (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@359976

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/split-flow-anonymous-wrapper-crash-expected.txt ('k') | LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/split-inline-wrong-post-block-crash-expected.txt » ('j') | LayoutTests/fast/multicol/span/adjacent-spanners.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/split-inline-wrong-post-block-crash.html

diff --git a/LayoutTests/fast/multicol/span/split-inline-wrong-post-block-crash.html b/LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/split-inline-wrong-post-block-crash.html

similarity index 85%

copy from LayoutTests/fast/multicol/span/split-inline-wrong-post-block-crash.html

copy to LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/split-inline-wrong-post-block-crash.html

index 392046563fcc851fed174e37f7ba53a8392d2066..716f62472b2ff702cc068d06432dd10ee4a59287 100644

--- a/LayoutTests/fast/multicol/span/split-inline-wrong-post-block-crash.html

+++ b/LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/split-inline-wrong-post-block-crash.html

@@ -1,6 +1,8 @@

<html>

<head>

+if (window.internals)

+ internals.settings.setRegionBasedColumnsEnabled(true);

if (window.testRunner)

testRunner.dumpAsText();

@@ -11,7 +13,7 @@ function runTest() {

var test1 = document.createElement('div');

test1.style['-webkit-column-span'] = 'all';

container.appendChild(test1);

- var test2 = document.createElement('span');

+ var test2 = document.createElement('span');

container.appendChild(test2);

test2.appendChild(document.createElement('div'));

var test3 = document.createElement('div');