LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/split-inline-wrong-post-block-crash.html - Issue 296413007: [New Multicolumn] Add support for column-span:all

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/split-inline-wrong-post-block-crash.html

Issue 296413007: [New Multicolumn] Add support for column-span:all (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@359976

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/split-flow-anonymous-wrapper-crash-expected.txt ('k') | LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/split-inline-wrong-post-block-crash-expected.txt » ('j') | LayoutTests/fast/multicol/span/adjacent-spanners.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script>	3 <script>

	4 if (window.internals)

	5 internals.settings.setRegionBasedColumnsEnabled(true);

4 if (window.testRunner)	6 if (window.testRunner)

5 testRunner.dumpAsText();	7 testRunner.dumpAsText();

6	8

7 function runTest() {	9 function runTest() {

8 var container = document.createElement('div');	10 var container = document.createElement('div');

9 container.style['-webkit-column-count'] = 1;	11 container.style['-webkit-column-count'] = 1;

10 document.body.appendChild(container);	12 document.body.appendChild(container);

11 var test1 = document.createElement('div');	13 var test1 = document.createElement('div');

12 test1.style['-webkit-column-span'] = 'all';	14 test1.style['-webkit-column-span'] = 'all';

13 container.appendChild(test1);	15 container.appendChild(test1);

14 var test2 = document.createElement('span');	16 var test2 = document.createElement('span');

15 container.appendChild(test2);	17 container.appendChild(test2);

16 test2.appendChild(document.createElement('div'));	18 test2.appendChild(document.createElement('div'));

17 var test3 = document.createElement('div');	19 var test3 = document.createElement('div');

18 test3.style.display = 'table-column';	20 test3.style.display = 'table-column';

19 container.appendChild(test3);	21 container.appendChild(test3);

20 container.appendChild(document.createElement('div'));	22 container.appendChild(document.createElement('div'));

21 }	23 }

22 </script>	24 </script>

23 </head>	25 </head>

24 <body onload="runTest()">	26 <body onload="runTest()">

25 Test passes if it does not crash.	27 Test passes if it does not crash.

26 </body>	28 </body>

27 </html>	29 </html>

OLD	NEW