LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/positioned-objects-not-removed-crash.html - Issue 296413007: [New Multicolumn] Add support for column-span:all

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/positioned-objects-not-removed-crash.html

Issue 296413007: [New Multicolumn] Add support for column-span:all (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@359976

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/positioned-child-not-removed-crash-expected.txt ('k') | LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/positioned-objects-not-removed-crash-expected.txt » ('j') | LayoutTests/fast/multicol/span/adjacent-spanners.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/positioned-objects-not-removed-crash.html

diff --git a/LayoutTests/fast/multicol/span/positioned-objects-not-removed-crash.html b/LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/positioned-objects-not-removed-crash.html

similarity index 73%

copy from LayoutTests/fast/multicol/span/positioned-objects-not-removed-crash.html

copy to LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/positioned-objects-not-removed-crash.html

index 5e4a1f41550a690e63afd8b337f2cd3244232c4c..c09ac9e41dba35037b776045e45461a131ce2062 100644

--- a/LayoutTests/fast/multicol/span/positioned-objects-not-removed-crash.html

+++ b/LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/positioned-objects-not-removed-crash.html

@@ -2,16 +2,18 @@

<html>

<body>

<style>

-#test0 { -webkit-columns: 1px; }

+#test0 { -webkit-columns: 1px; }

#test1 { -webkit-perspective: 1; display: compact; }

-#test1:before { content: ""; }

-#test1:after { display: table; content: ""; }

+#test1:before { content: ""; }

+#test1:after { display: table; content: ""; }

#test2 { -webkit-column-span: all; }

-#test4:last-child { position:fixed; }

-.c0 { display: table-header-group; }

+#test4:last-child { position:fixed; }

+.c0 { display: table-header-group; }

.c1:first-letter { content: ""; }

</style>

+if (window.internals)

+ internals.settings.setRegionBasedColumnsEnabled(true);

if (window.testRunner)

testRunner.dumpAsText();

@@ -28,10 +30,10 @@ onload = function() {

test3 = document.createElement('span');

test1.appendChild(test3);

test4 = document.createElement('div');

- test4.setAttribute('id', 'test4');

+ test4.setAttribute('id', 'test4');

test3.appendChild(test4);

document.body.offsetTop;

- test2.setAttribute('class', 'c0');

+ test2.setAttribute('class', 'c0');

test4.setAttribute('class', 'c1');

document.body.offsetTop;

document.body.innerHTML = "WebKit Bug - Crash in multi-column layout.<br />PASS. WebKit didn't crash.";