LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/positioned-objects-not-removed-crash.html - Issue 296413007: [New Multicolumn] Add support for column-span:all

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/positioned-objects-not-removed-crash.html

Issue 296413007: [New Multicolumn] Add support for column-span:all (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@359976

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/positioned-child-not-removed-crash-expected.txt ('k') | LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/positioned-objects-not-removed-crash-expected.txt » ('j') | LayoutTests/fast/multicol/span/adjacent-spanners.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <body>	3 <body>

4 <style>	4 <style>

5 #test0 { -webkit-columns: 1px; }	5 #test0 { -webkit-columns: 1px; }

6 #test1 { -webkit-perspective: 1; display: compact; }	6 #test1 { -webkit-perspective: 1; display: compact; }

7 #test1:before { content: ""; }	7 #test1:before { content: ""; }

8 #test1:after { display: table; content: ""; }	8 #test1:after { display: table; content: ""; }

9 #test2 { -webkit-column-span: all; }	9 #test2 { -webkit-column-span: all; }

10 #test4:last-child { position:fixed; }	10 #test4:last-child { position:fixed; }

11 .c0 { display: table-header-group; }	11 .c0 { display: table-header-group; }

12 .c1:first-letter { content: ""; }	12 .c1:first-letter { content: ""; }

13 </style>	13 </style>

14 <script>	14 <script>

	15 if (window.internals)

	16 internals.settings.setRegionBasedColumnsEnabled(true);

15 if (window.testRunner)	17 if (window.testRunner)

16 testRunner.dumpAsText();	18 testRunner.dumpAsText();

17	19

18 onload = function() {	20 onload = function() {

19 test0 = document.createElement('div');	21 test0 = document.createElement('div');

20 test0.setAttribute('id', 'test0');	22 test0.setAttribute('id', 'test0');

21 document.body.appendChild(test0);	23 document.body.appendChild(test0);

22 test1 = document.createElement('div');	24 test1 = document.createElement('div');

23 test1.setAttribute('id','test1');	25 test1.setAttribute('id','test1');

24 test0.appendChild(test1);	26 test0.appendChild(test1);

25 test2 = document.createElement('div');	27 test2 = document.createElement('div');

26 test2.setAttribute('id','test2');	28 test2.setAttribute('id','test2');

27 test1.appendChild(test2);	29 test1.appendChild(test2);

28 test3 = document.createElement('span');	30 test3 = document.createElement('span');

29 test1.appendChild(test3);	31 test1.appendChild(test3);

30 test4 = document.createElement('div');	32 test4 = document.createElement('div');

31 test4.setAttribute('id', 'test4');	33 test4.setAttribute('id', 'test4');

32 test3.appendChild(test4);	34 test3.appendChild(test4);

33 document.body.offsetTop;	35 document.body.offsetTop;

34 test2.setAttribute('class', 'c0');	36 test2.setAttribute('class', 'c0');

35 test4.setAttribute('class', 'c1');	37 test4.setAttribute('class', 'c1');

36 document.body.offsetTop;	38 document.body.offsetTop;

37 document.body.innerHTML = "WebKit Bug - Crash in multi-column layout.<br />P ASS. WebKit didn't crash.";	39 document.body.innerHTML = "WebKit Bug - Crash in multi-column layout.<br />P ASS. WebKit didn't crash.";

38 }	40 }

39 </script>	41 </script>

40 </body>	42 </body>

41 </html>	43 </html>

OLD	NEW