Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Issue 2964003: Make kCookiePromptExpanded a profile pref rather than a local state pref so it can be synced. (Closed)

Created:
10 years, 5 months ago by skrul
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, Raghu Simha, ncarter (slow), idana, tim (not reviewing), ben+cc_chromium.org
Visibility:
Public.

Description

Make kCookiePromptExpanded a profile pref rather than a local state pref so it can be synced. BUG=40483 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52142

Patch Set 1 #

Patch Set 2 : Finish code for gtk. #

Patch Set 3 : Windows changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -21 lines) Patch
M chrome/browser/browser_prefs.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/cookie_modal_dialog.h View 1 4 chunks +14 lines, -1 line 0 comments Download
M chrome/browser/cookie_modal_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cookie_modal_dialog_gtk.cc View 1 3 chunks +10 lines, -13 lines 0 comments Download
M chrome/browser/sync/glue/synchronized_preferences.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/views/cookie_prompt_view.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/views/cookie_prompt_view.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
skrul
10 years, 5 months ago (2010-07-12 18:43:54 UTC) #1
sky
10 years, 5 months ago (2010-07-12 19:37:47 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698