Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2963963003: config_service: Added google-signin-aware.html for Polymer 2.0. (Closed)

Created:
3 years, 5 months ago by cwpayton
Modified:
3 years, 5 months ago
Reviewers:
Sergey Berezin, hinoka
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

config_service: Added google-signin-aware.html for Polymer 2.0. This is the original file that was pulled from Scarygami's 2.0-preview branch of the Google Web Component google-signin-aware. This CL is being uploaded so that my changes to this file can be viewed in another CL. The link to this particular file can be found here: https://github.com/Scarygami/google-signin/blob/599547e042ae4e5dec21051953754eec93fe26ca/google-signin-aware.html BUG=730832 Review-Url: https://codereview.chromium.org/2963963003 Committed: https://github.com/luci/luci-py/commit/71c3c10aecb784a070f19d47eabb4ccfebc6c6c2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+824 lines, -0 lines) Patch
A appengine/config_service/ui/common/third-party/google-signin-aware.html View 1 chunk +824 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
cwpayton
I uploaded the original google-signin-aware.html file to this CL, as per description. This way we'll ...
3 years, 5 months ago (2017-06-29 16:36:26 UTC) #2
Sergey Berezin
Thanks, LGTM! Before landing, in the CL *description* please add the direct link to the ...
3 years, 5 months ago (2017-06-29 17:17:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2963963003/1
3 years, 5 months ago (2017-06-29 17:25:18 UTC) #7
commit-bot: I haz the power
3 years, 5 months ago (2017-06-29 17:27:29 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/71c3c10aecb784a070f19d47eabb4ccfebc6c6c2

Powered by Google App Engine
This is Rietveld 408576698