Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1162)

Issue 2963943002: Upstream for a thing

Created:
3 years, 5 months ago by tapted
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews, jdonnelly+watch_chromium.org, yusukes+watch_chromium.org, tfarina, shuchen+watch_chromium.org, dcheng, nona+watch_chromium.org, mac-reviews_chromium.org, James Su, bruthig+ink_drop_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream for a thing https://codereview.chromium.org/2964453002/ https://codereview.chromium.org/2963083003/ https://codereview.chromium.org/2960393002/ Use style::CONTEXT_TEXTFIELD for Combobox and Textfield Use kColorId_LabelEnabledColor in Checkbox, not kColorId_ButtonEnabledColor Hardcode ripple color/opacity for Harmony. BUG=691891

Patch Set 1 #

Patch Set 2 : testfix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -58 lines) Patch
M chrome/browser/ui/views/harmony/harmony_typography_provider.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc View 4 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/views/payments/validating_textfield_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/animation/ink_drop_host_view.h View 2 chunks +13 lines, -3 lines 0 comments Download
M ui/views/animation/ink_drop_host_view.cc View 5 chunks +28 lines, -5 lines 0 comments Download
M ui/views/cocoa/bridged_native_widget_unittest.mm View 1 2 chunks +6 lines, -0 lines 0 comments Download
M ui/views/controls/button/checkbox.cc View 3 chunks +5 lines, -10 lines 0 comments Download
M ui/views/controls/button/label_button.cc View 2 chunks +5 lines, -9 lines 0 comments Download
M ui/views/controls/button/md_text_button.h View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/views/controls/button/md_text_button.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M ui/views/controls/combobox/combobox.cc View 6 chunks +16 lines, -16 lines 0 comments Download
M ui/views/controls/textfield/textfield.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/style/typography_provider.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Dependent Patchsets:

Powered by Google App Engine
This is Rietveld 408576698