Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2961223002: Rename native theme color constants relating to text on dialog buttons

Created:
3 years, 5 months ago by tapted
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename native theme color constants relating to text on dialog buttons It's currently ambiguous whether these colors are the button color or the text color. BUG=691891

Patch Set 1 #

Patch Set 2 : Rebase off 3 other CLs yay spaghetti #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -31 lines) Patch
M chrome/browser/ui/libgtkui/native_theme_gtk2.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/libgtkui/native_theme_gtk3.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/native_theme/common_theme.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/native_theme/native_theme.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/native_theme/native_theme_dark_aura.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/native_theme/native_theme_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/native_theme/native_theme_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/label_button.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M ui/views/controls/button/label_button_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/md_text_button.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/tabbed_pane/tabbed_pane.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (8 generated)
tapted
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
3 years, 5 months ago (2017-06-29 06:50:18 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2961223002/20001
3 years, 5 months ago (2017-06-29 06:50:42 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-06-29 07:05:45 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/300830)
3 years, 5 months ago (2017-06-29 07:05:47 UTC) #4
tapted
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
3 years, 5 months ago (2017-06-29 07:53:46 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2961223002/40001
3 years, 5 months ago (2017-06-29 07:53:58 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-06-29 09:40:59 UTC) #7
commit-bot: I haz the power
3 years, 5 months ago (2017-06-29 09:41:01 UTC) #8 
Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698