Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 2963793002: Enable scrolling of main content in CCT client app. (Closed)

Created:
3 years, 5 months ago by Ted C
Modified:
3 years, 5 months ago
Reviewers:
Yusuf
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Enable scrolling of main content in CCT client app. Right now, the app content doesn't scroll if you are in landscape or on shorter devices in portrait (or if you enter multi-window). This simply wraps the main content in a ScrollView to allow interacting with all components in these constrained layouts. BUG= Review-Url: https://codereview.chromium.org/2963793002 Committed: https://github.com/GoogleChrome/custom-tabs-client/commit/08bd54d3b9ef387c54cc4d4967a400b27c394e05

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -76 lines) Patch
M Application/src/main/res/layout/main.xml View 1 chunk +84 lines, -76 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Ted C
PTAL
3 years, 5 months ago (2017-06-28 16:12:21 UTC) #2
Yusuf
lgtm
3 years, 5 months ago (2017-06-29 06:08:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2963793002/1
3 years, 5 months ago (2017-06-29 06:08:56 UTC) #5
commit-bot: I haz the power
3 years, 5 months ago (2017-06-29 06:09:50 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/GoogleChrome/custom-tabs-client/commit/08bd54d3b9ef387c54c...

Powered by Google App Engine
This is Rietveld 408576698