Stop exporting ComputedStyle.

Stop exporting ComputedStyle.

Exporting this class alone is respoonsible for 25% of the size of
blink_core.ilk, and most of it doesn't have to be exported.
Manually export the few (non-inline) functions that need this.
This CL reduces the size of blink_core.ilk from 2.59GB to 1.94GB.
(I'm at #475088 -- the win is likely smaller, but still substantial,
after https://chromium-review.googlesource.com/543155)

(One side effect is that the address of the inline functions might
end up different in different dlls, but that seems ok.)

BUG=560475
Review-Url: https://codereview.chromium.org/2963773002
Cr-Commit-Position: refs/heads/master@{#483051}
Committed: https://chromium.googlesource.com/chromium/src/+/23768d32b212f3dbb00965c87a1b892d3ae6f634

[Nico, 2017-06-28 13:21:46]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 13:21:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 13:43:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 13:43:18]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Nico, 2017-06-28 13:51:50]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 13:52:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 14:14:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 14:14:16]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Nico, 2017-06-28 14:19:46]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 14:20:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 15:02:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 15:02:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nico, 2017-06-28 15:31:45]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 15:31:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-06-28 16:51:41]

Description was changed from

==========
Stop exporting ComputedStyle.

Exporting this class alone is respoonsible for 15% of the size of
blink_core.ilk,
and it looks like it's not even necessary to export it.

BUG=560475
==========

to

==========
Stop exporting ComputedStyle.

Manually export the few (non-inline) functions that need this.

Exporting this class alone is respoonsible for 15% of the size of
blink_core.ilk,
and it looks like it's not even necessary to export it.

(One side effect is that the address of the inline functions might
end up different in different dlls, but that seems ok.)

BUG=560475
==========

[Nico, 2017-06-28 16:52:15]

Description was changed from

==========
Stop exporting ComputedStyle.

Manually export the few (non-inline) functions that need this.

Exporting this class alone is respoonsible for 15% of the size of
blink_core.ilk,
and it looks like it's not even necessary to export it.

(One side effect is that the address of the inline functions might
end up different in different dlls, but that seems ok.)

BUG=560475
==========

to

==========
Stop exporting ComputedStyle.


Exporting this class alone is respoonsible for 15% of the size of
blink_core.ilk, and most of it doesn't have to be exported.
Manually export the few (non-inline) functions that need this.

(One side effect is that the address of the inline functions might
end up different in different dlls, but that seems ok.)

BUG=560475
==========

[Nico, 2017-06-28 17:15:12]

Description was changed from

==========
Stop exporting ComputedStyle.


Exporting this class alone is respoonsible for 15% of the size of
blink_core.ilk, and most of it doesn't have to be exported.
Manually export the few (non-inline) functions that need this.

(One side effect is that the address of the inline functions might
end up different in different dlls, but that seems ok.)

BUG=560475
==========

to

==========
Stop exporting ComputedStyle.

Exporting this class alone is respoonsible for 15% of the size of
blink_core.ilk, and most of it doesn't have to be exported.
Manually export the few (non-inline) functions that need this.
This CL reduces the size of blink_core.ilk from 2.59GB to 1.94GB.

(One side effect is that the address of the inline functions might
end up different in different dlls, but that seems ok.)

BUG=560475
==========

[Nico, 2017-06-28 17:15:42]

Description was changed from

==========
Stop exporting ComputedStyle.

Exporting this class alone is respoonsible for 15% of the size of
blink_core.ilk, and most of it doesn't have to be exported.
Manually export the few (non-inline) functions that need this.
This CL reduces the size of blink_core.ilk from 2.59GB to 1.94GB.

(One side effect is that the address of the inline functions might
end up different in different dlls, but that seems ok.)

BUG=560475
==========

to

==========
Stop exporting ComputedStyle.

Exporting this class alone is respoonsible for 25% of the size of
blink_core.ilk, and most of it doesn't have to be exported.
Manually export the few (non-inline) functions that need this.
This CL reduces the size of blink_core.ilk from 2.59GB to 1.94GB.

(One side effect is that the address of the inline functions might
end up different in different dlls, but that seems ok.)

BUG=560475
==========

[Nico, 2017-06-28 17:16:57]

thakis@chromium.org changed reviewers:
+ pdr@chromium.org

[Nico, 2017-06-28 17:16:58]

pdr: This supersedes that other BLINK_EXPORT CL for generated files I sent you a
while ago.

rnk: After rerunning the numbers for this patch, I think we really really want
-fvisibility-inlines-hidden.

[commit-bot: I haz the power, 2017-06-28 17:30:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 17:30:37]

Dry run: This issue passed the CQ dry run.

[pdr., 2017-06-28 17:32:04]

On 2017/06/28 at 17:16:58, thakis wrote:
> pdr: This supersedes that other BLINK_EXPORT CL for generated files I sent you
a while ago.
> 
> rnk: After rerunning the numbers for this patch, I think we really really want
-fvisibility-inlines-hidden.

This adds almost no complexity and is a win. LGTM

[Nico, 2017-06-28 17:32:48]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2017-06-28 17:33:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-06-28 17:35:13]

Description was changed from

==========
Stop exporting ComputedStyle.

Exporting this class alone is respoonsible for 25% of the size of
blink_core.ilk, and most of it doesn't have to be exported.
Manually export the few (non-inline) functions that need this.
This CL reduces the size of blink_core.ilk from 2.59GB to 1.94GB.

(One side effect is that the address of the inline functions might
end up different in different dlls, but that seems ok.)

BUG=560475
==========

to

==========
Stop exporting ComputedStyle.

Exporting this class alone is respoonsible for 25% of the size of
blink_core.ilk, and most of it doesn't have to be exported.
Manually export the few (non-inline) functions that need this.
This CL reduces the size of blink_core.ilk from 2.59GB to 1.94GB.
(I'm at #475088.)

(One side effect is that the address of the inline functions might
end up different in different dlls, but that seems ok.)

BUG=560475
==========

[Nico, 2017-06-28 17:35:30]

Description was changed from

==========
Stop exporting ComputedStyle.

Exporting this class alone is respoonsible for 25% of the size of
blink_core.ilk, and most of it doesn't have to be exported.
Manually export the few (non-inline) functions that need this.
This CL reduces the size of blink_core.ilk from 2.59GB to 1.94GB.
(I'm at #475088.)

(One side effect is that the address of the inline functions might
end up different in different dlls, but that seems ok.)

BUG=560475
==========

to

==========
Stop exporting ComputedStyle.

Exporting this class alone is respoonsible for 25% of the size of
blink_core.ilk, and most of it doesn't have to be exported.
Manually export the few (non-inline) functions that need this.
This CL reduces the size of blink_core.ilk from 2.59GB to 1.94GB.
(I'm at #475088 -- the win is likely smaller, but still substantial,
after https://chromium-review.googlesource.com/543155)

(One side effect is that the address of the inline functions might
end up different in different dlls, but that seems ok.)

BUG=560475
==========

[commit-bot: I haz the power, 2017-06-28 17:37:03]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1498671168264500,
"parent_rev": "9a9f631f218e12a1a246cef8445a6cf8845a1425", "commit_rev":
"08591b48f00790e357fed975a930fb3b2138d0fa"}

[commit-bot: I haz the power, 2017-06-28 17:37:17]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1498671168264500,
"parent_rev": "801496fdcdf08a42a21435cdc358e64abeccc554", "commit_rev":
"23768d32b212f3dbb00965c87a1b892d3ae6f634"}

[commit-bot: I haz the power, 2017-06-28 17:37:32]

Description was changed from

==========
Stop exporting ComputedStyle.

Exporting this class alone is respoonsible for 25% of the size of
blink_core.ilk, and most of it doesn't have to be exported.
Manually export the few (non-inline) functions that need this.
This CL reduces the size of blink_core.ilk from 2.59GB to 1.94GB.
(I'm at #475088 -- the win is likely smaller, but still substantial,
after https://chromium-review.googlesource.com/543155)

(One side effect is that the address of the inline functions might
end up different in different dlls, but that seems ok.)

BUG=560475
==========

to

==========
Stop exporting ComputedStyle.

Exporting this class alone is respoonsible for 25% of the size of
blink_core.ilk, and most of it doesn't have to be exported.
Manually export the few (non-inline) functions that need this.
This CL reduces the size of blink_core.ilk from 2.59GB to 1.94GB.
(I'm at #475088 -- the win is likely smaller, but still substantial,
after https://chromium-review.googlesource.com/543155)

(One side effect is that the address of the inline functions might
end up different in different dlls, but that seems ok.)

BUG=560475

Review-Url: https://codereview.chromium.org/2963773002
Cr-Commit-Position: refs/heads/master@{#483051}
Committed:
https://chromium.googlesource.com/chromium/src/+/23768d32b212f3dbb00965c87a1b...
==========

[commit-bot: I haz the power, 2017-06-28 17:37:33]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/23768d32b212f3dbb00965c87a1b...