Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2963733003: Scripts for unity/jumbo (default disabled) compilation (Closed)

Created:
3 years, 5 months ago by Daniel Bratell
Modified:
3 years, 5 months ago
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-html_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Scripts for unity/jumbo (default disabled) compilation. To speed up compilation times, jumbo allows files to be compiled together. This is a well known method ("unity builds") to both compile faster and create a poor man's "full program optimization". For Chromium we are only interested in the compile times. This patch includes the basic scripts that do the source file merging and changes Blink Core to use those scripts. If the gn configuration includes: use_jumbo_build = true then Blink Core will use jumbo compile. Otherwise it will compile as usual. The expected speedup from using Jumbo on Blink Core (and nothing else) is about 17% of the content_shell+blink_tests compilation CPU time. This is about half an hour for people building with an ordinary computer, but less both in percentage and minutes if using some kind of build accelerator like goma. More information in https://docs.google.com/document/d/19jGsZxh7DX8jkAKbL1nYBa5rcByUL2EeidnYsoXfsYQ/edit# BUG=713137 Review-Url: https://codereview.chromium.org/2963733003 Cr-Commit-Position: refs/heads/master@{#483986} Committed: https://chromium.googlesource.com/chromium/src/+/45a1ceb8309b6076aea7d2885b7a62f8d3c549c9

Patch Set 1 #

Total comments: 13

Patch Set 2 : Moved files and changed some names #

Total comments: 19

Patch Set 3 : Addressed review issues. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -10 lines) Patch
A build/config/jumbo.gni View 1 2 1 chunk +146 lines, -0 lines 0 comments Download
A build/config/merge_for_jumbo.py View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/core.gni View 1 2 chunks +11 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/exported/BUILD.gn View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/BUILD.gn View 1 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/BUILD.gn View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 30 (19 generated)
Daniel Bratell
dpranke, this is a basic jumbo patch with it default disabled. If this lands, it ...
3 years, 5 months ago (2017-06-28 14:31:00 UTC) #5
Dirk Pranke
This basically looks okay, although I still think that ultimately we'll want to bake this ...
3 years, 5 months ago (2017-06-29 23:09:46 UTC) #9
Dirk Pranke
On 2017/06/28 14:31:00, Daniel Bratell wrote: > I am not sure whether jumbo.gni and jumbo.py ...
3 years, 5 months ago (2017-06-29 23:31:24 UTC) #10
Daniel Bratell
https://codereview.chromium.org/2963733003/diff/1/build/jumbo.gni File build/jumbo.gni (right): https://codereview.chromium.org/2963733003/diff/1/build/jumbo.gni#newcode10 build/jumbo.gni:10: use_blink_jumbo_build = false On 2017/06/29 23:09:46, Dirk Pranke wrote: ...
3 years, 5 months ago (2017-06-30 08:22:20 UTC) #11
Daniel Bratell
On 2017/06/29 23:09:46, Dirk Pranke wrote: > This basically looks okay, although I still think ...
3 years, 5 months ago (2017-06-30 08:44:20 UTC) #12
Daniel Bratell
Please take a new look. Fixed the things you mentioned I think. The patch still ...
3 years, 5 months ago (2017-06-30 10:09:53 UTC) #13
brucedawson
Thanks for doing this work. lgtm if dpranke@ is satisfied (I just did a quick ...
3 years, 5 months ago (2017-06-30 18:49:15 UTC) #18
Dirk Pranke
This basically lgtm, though I have lots of nits :). I guess I can live ...
3 years, 5 months ago (2017-06-30 21:38:46 UTC) #19
Daniel Bratell
https://codereview.chromium.org/2963733003/diff/20001/build/config/jumbo.gni File build/config/jumbo.gni (right): https://codereview.chromium.org/2963733003/diff/20001/build/config/jumbo.gni#newcode9 build/config/jumbo.gni:9: # compilation. On 2017/06/30 21:38:46, Dirk Pranke wrote: > ...
3 years, 5 months ago (2017-07-03 09:21:17 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2963733003/40001
3 years, 5 months ago (2017-07-03 10:08:34 UTC) #27
commit-bot: I haz the power
3 years, 5 months ago (2017-07-03 11:14:54 UTC) #30
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/45a1ceb8309b6076aea7d2885b7a...

Powered by Google App Engine
This is Rietveld 408576698