Add type inference of annotations.

Add type inference of annotations.

Note that some locations where annotations can occur are not yet
supported by kernel and/or fasta, so there are some test failures.

R=ahe@google.com

Committed: https://github.com/dart-lang/sdk/commit/9994caf4e25844d507b861c3076b5a573fa9c37f

[Paul Berry, 2017-06-28 04:55:16]

paulberry@google.com changed reviewers:
+ ahe@google.com

[ahe, 2017-06-28 07:39:50]

lgtm

https://codereview.chromium.org/2963703002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2963703002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:449:
_typeInferrer.inferMetadata(annotations);
Can you move all these calls to endMetadataStar? And then remove finishMetadata?

[Paul Berry, 2017-06-28 12:15:59]

https://codereview.chromium.org/2963703002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2963703002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:449:
_typeInferrer.inferMetadata(annotations);
On 2017/06/28 07:39:49, ahe wrote:
> Can you move all these calls to endMetadataStar? And then remove
finishMetadata?

I could do that now, but it would not work in the long term.  Once we have
support for annotations on local variables and local functions (see
https://github.com/dart-lang/sdk/issues/30031 and
https://github.com/dart-lang/sdk/issues/30035), we will have to ensure that type
inference for local annotations happens during the type inference phase, so that
code like this will infer correctly:

  class Foo {
    const Foo(dynamic x);
  }
  void test() {
    const x = 0; // Infers as: const int x = 0;
    @Foo([x]) // Infers as: @Foo(<int>[x])
    int y;
  }

Leaving as is for now.  If you have strong feelings about this, let me know and
we can discuss.

[Paul Berry, 2017-06-28 12:30:28]

Description was changed from

==========
Add type inference of annotations.

Note that some locations where annotations can occur are not yet
supported by kernel and/or fasta, so there are some test failures.
==========

to

==========
Add type inference of annotations.

Note that some locations where annotations can occur are not yet
supported by kernel and/or fasta, so there are some test failures.

R=ahe@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9994caf4e25844d507b861c3076b5a573fa9c37f
==========

[Paul Berry, 2017-06-28 12:30:29]

Committed patchset #1 (id:1) manually as
9994caf4e25844d507b861c3076b5a573fa9c37f.