Chromium Code Reviews| Index: chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/UrlBarTest.java |
| diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/UrlBarTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/UrlBarTest.java |
| index 01225c11cee8357acf9f02d4b35488025b026dd6..acdf2db443d2d4cb7544e088f6ea515a18528699 100644 |
| --- a/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/UrlBarTest.java |
| +++ b/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/UrlBarTest.java |
| @@ -31,8 +31,7 @@ import org.chromium.base.test.util.CommandLineFlags; |
| import org.chromium.base.test.util.Feature; |
| import org.chromium.base.test.util.Restriction; |
| import org.chromium.base.test.util.RetryOnFailure; |
| -import org.chromium.base.test.util.parameter.Parameter; |
| -import org.chromium.base.test.util.parameter.ParameterizedTest; |
| +import org.chromium.base.test.util.parameter.JUnit3CommandLineParameter; |
| import org.chromium.chrome.R; |
| import org.chromium.chrome.browser.ChromeActivity; |
| import org.chromium.chrome.browser.ChromeFeatureList; |
| @@ -54,23 +53,15 @@ import java.util.concurrent.atomic.AtomicReference; |
| /** |
| * Tests for the URL bar UI component. |
| + * |
| + * TODO(yolandyan): Replace the JUnit3CommandLineParameter with new JUnit4 parameterized |
| + * framework once it supports Test Rule Parameterization |
| */ |
| @RunWith(ChromeJUnit4ClassRunner.class) |
| @CommandLineFlags.Add({ChromeSwitches.DISABLE_FIRST_RUN_EXPERIENCE, |
| ChromeActivityTestRule.DISABLE_NETWORK_PREDICTION_FLAG}) |
| -@ParameterizedTest.Set(tests = { |
| - @ParameterizedTest(parameters = { |
| - @Parameter( |
| - tag = CommandLineFlags.Parameter.PARAMETER_TAG)}), |
| - @ParameterizedTest(parameters = { |
| - @Parameter( |
| - tag = CommandLineFlags.Parameter.PARAMETER_TAG, |
| - arguments = { |
| - @Parameter.Argument( |
| - name = CommandLineFlags.Parameter.ADD_ARG, |
| - stringArray = {"enable-features=" |
| - + ChromeFeatureList.SPANNABLE_INLINE_AUTOCOMPLETE}) |
| - })})}) |
| +@JUnit3CommandLineParameter({"", |
| + "enable-features=" + ChromeFeatureList.SPANNABLE_INLINE_AUTOCOMPLETE}) |
|
Changwan Ryu
2017/07/11 04:36:42
ditto here - I'd prefer that we run the tests with
|
| public class UrlBarTest { |
| // 9000+ chars of goodness |