Simplify CommandLine parameterizing J3 Instrumentation Tests

chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java

Index: chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java
index 0e897e1dee92028a8df2139ef7ff4453c3e1c17c..dc3df83b320bf6e235eb3a7b134f3e5848159f11 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java
@@ -35,8 +35,7 @@ import org.chromium.base.test.util.FlakyTest;
 import org.chromium.base.test.util.MinAndroidSdkLevel;
 import org.chromium.base.test.util.RetryOnFailure;
 import org.chromium.base.test.util.ScalableTimeout;
-import org.chromium.base.test.util.parameter.Parameter;
-import org.chromium.base.test.util.parameter.ParameterizedTest;
+import org.chromium.base.test.util.parameter.JUnit3CommandLineParameter;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.ChromeActivity;
 import org.chromium.chrome.browser.ChromeFeatureList;
@@ -69,23 +68,15 @@ import java.util.concurrent.atomic.AtomicInteger;
 
 /**
  * Tests of the Omnibox.
+ *
+ * TODO(yolandyan): Replace the JUnit3CommandLineParameter with new JUnit4 parameterized
+ * framework once it supports Test Rule Parameterization
  */
 @RunWith(ChromeJUnit4ClassRunner.class)
 @CommandLineFlags.Add({ChromeSwitches.DISABLE_FIRST_RUN_EXPERIENCE,
         ChromeActivityTestRule.DISABLE_NETWORK_PREDICTION_FLAG})
-@ParameterizedTest.Set(tests = {
-        @ParameterizedTest(parameters = {
-                @Parameter(
-                        tag = CommandLineFlags.Parameter.PARAMETER_TAG)}),
-        @ParameterizedTest(parameters = {
-                @Parameter(
-                        tag = CommandLineFlags.Parameter.PARAMETER_TAG,
-                        arguments = {
-                                @Parameter.Argument(
-                                        name = CommandLineFlags.Parameter.ADD_ARG,
-                                        stringArray = {"enable-features="
-                                                + ChromeFeatureList.SPANNABLE_INLINE_AUTOCOMPLETE})
-        })})})
+@JUnit3CommandLineParameter({"",
+        "enable-features=" + ChromeFeatureList.SPANNABLE_INLINE_AUTOCOMPLETE})

[Changwan Ryu, 2017/07/11 04:36:42]

Hmm... If we have to choose one case, I'd prefer to keep the existing case
running. Any new regression here would be a serious one. I'll have to run all
the tests locally till the full migration.

[the real yoland, 2017/07/11 17:46:51]

The existing case would not work with our harness change (listing test from java
runner), unfortunately :(
But these two does exactly the same thing since both annotations are picked up
on python side and parameterize tests from
python side

 public class OmniboxTest {
     @Rule
     public ChromeActivityTestRule<ChromeActivity> mActivityTestRule =