Fix Cronet tests.

Fix Cronet tests.

These were broken when URLRequestContextBuilder was switched over to
using task_scheduler by default in
https://codereview.chromium.org/2951813002/.

The fix is to instantiate a base::test::ScopedTaskEnvironment instead
of a MessageLoopForIO.

BUG=715695, 737326
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2963643002
Cr-Commit-Position: refs/heads/master@{#482965}
Committed: https://chromium.googlesource.com/chromium/src/+/51629db1e4abd11d33150d7fc0a2207c0fc5cd9c

[mmenke, 2017-06-27 22:12:08]

Description was changed from

==========
Fix Cronet tests.

These were broken when URLRequestContextBuilder was switched over to
using task_scheduler by default in
https://codereview.chromium.org/2951813002/.

BUG=715695
==========

to

==========
Fix Cronet tests.

These were broken when URLRequestContextBuilder was switched over to
using task_scheduler by default in
https://codereview.chromium.org/2951813002/.

BUG=715695
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[mmenke, 2017-06-27 22:12:21]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 22:12:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-06-27 22:13:59]

mmenke@chromium.org changed reviewers:
+ pauljensen@chromium.org

[mmenke, 2017-06-27 22:14:00]

I'm breaking Cronet in all sorts of fun and exciting ways!  Haven't tested this
yet, just sending it out now to make it clear I'm intending to fix it.

[mmenke, 2017-06-27 22:15:12]

Description was changed from

==========
Fix Cronet tests.

These were broken when URLRequestContextBuilder was switched over to
using task_scheduler by default in
https://codereview.chromium.org/2951813002/.

BUG=715695
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Fix Cronet tests.

These were broken when URLRequestContextBuilder was switched over to
using task_scheduler by default in
https://codereview.chromium.org/2951813002/.

The fix is to instantiate a base::test::ScopedTaskEnvironment instead of
a MessageLoopForIO.

BUG=715695
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[mmenke, 2017-06-27 22:15:26]

Description was changed from

==========
Fix Cronet tests.

These were broken when URLRequestContextBuilder was switched over to
using task_scheduler by default in
https://codereview.chromium.org/2951813002/.

The fix is to instantiate a base::test::ScopedTaskEnvironment instead of
a MessageLoopForIO.

BUG=715695
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Fix Cronet tests.

These were broken when URLRequestContextBuilder was switched over to
using task_scheduler by default in
https://codereview.chromium.org/2951813002/.

The fix is to instantiate a base::test::ScopedTaskEnvironment instead
of a MessageLoopForIO.

BUG=715695
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[commit-bot: I haz the power, 2017-06-27 22:18:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-27 22:18:46]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[mmenke, 2017-06-27 22:19:45]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 22:20:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 22:25:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-27 22:25:49]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[mmenke, 2017-06-27 22:32:08]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 22:32:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pauljensen, 2017-06-27 22:50:11]

https://codereview.chromium.org/2963643002/diff/20001/components/cronet/stale...
File components/cronet/stale_host_resolver_unittest.cc (right):

https://codereview.chromium.org/2963643002/diff/20001/components/cronet/stale...
components/cronet/stale_host_resolver_unittest.cc:87: mock_proc_(new
MockHostResolverProc()), resolver_(nullptr),
This indentation is wacky...I guess the formater has a bug...

[commit-bot: I haz the power, 2017-06-27 22:53:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-27 22:53:55]

Dry run: This issue passed the CQ dry run.

[mmenke, 2017-06-27 23:16:40]

On 2017/06/27 22:50:11, pauljensen wrote:
>
https://codereview.chromium.org/2963643002/diff/20001/components/cronet/stale...
> File components/cronet/stale_host_resolver_unittest.cc (right):
> 
>
https://codereview.chromium.org/2963643002/diff/20001/components/cronet/stale...
> components/cronet/stale_host_resolver_unittest.cc:87: mock_proc_(new
> MockHostResolverProc()), resolver_(nullptr),
> This indentation is wacky...I guess the formater has a bug...

Or maybe I forgot to run it - git cl format with no args seems to ignore cronet,
and I was skipping presubmit, since we have magic Android presubmit checks that
are borked on Windows.

[mmenke, 2017-06-27 23:16:43]

On 2017/06/27 22:50:11, pauljensen wrote:
>
https://codereview.chromium.org/2963643002/diff/20001/components/cronet/stale...
> File components/cronet/stale_host_resolver_unittest.cc (right):
> 
>
https://codereview.chromium.org/2963643002/diff/20001/components/cronet/stale...
> components/cronet/stale_host_resolver_unittest.cc:87: mock_proc_(new
> MockHostResolverProc()), resolver_(nullptr),
> This indentation is wacky...I guess the formater has a bug...

Or maybe I forgot to run it - git cl format with no args seems to ignore cronet,
and I was skipping presubmit, since we have magic Android presubmit checks that
are borked on Windows.

[mmenke, 2017-06-27 23:18:12]

On 2017/06/27 23:16:43, mmenke wrote:
> On 2017/06/27 22:50:11, pauljensen wrote:
> >
>
https://codereview.chromium.org/2963643002/diff/20001/components/cronet/stale...
> > File components/cronet/stale_host_resolver_unittest.cc (right):
> > 
> >
>
https://codereview.chromium.org/2963643002/diff/20001/components/cronet/stale...
> > components/cronet/stale_host_resolver_unittest.cc:87: mock_proc_(new
> > MockHostResolverProc()), resolver_(nullptr),
> > This indentation is wacky...I guess the formater has a bug...
> 
> Or maybe I forgot to run it - git cl format with no args seems to ignore
cronet,
> and I was skipping presubmit, since we have magic Android presubmit checks
that
> are borked on Windows.

I'll plan to clean up and land tomorrow.

[mmenke, 2017-06-28 12:32:57]

Description was changed from

==========
Fix Cronet tests.

These were broken when URLRequestContextBuilder was switched over to
using task_scheduler by default in
https://codereview.chromium.org/2951813002/.

The fix is to instantiate a base::test::ScopedTaskEnvironment instead
of a MessageLoopForIO.

BUG=715695
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Fix Cronet tests.

These were broken when URLRequestContextBuilder was switched over to
using task_scheduler by default in
https://codereview.chromium.org/2951813002/.

The fix is to instantiate a base::test::ScopedTaskEnvironment instead
of a MessageLoopForIO.

BUG=715695,737326
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[mmenke, 2017-06-28 12:36:01]

Merge, fix formatting

[mmenke, 2017-06-28 12:36:23]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 12:36:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-06-28 12:36:39]

https://codereview.chromium.org/2963643002/diff/20001/components/cronet/stale...
File components/cronet/stale_host_resolver_unittest.cc (right):

https://codereview.chromium.org/2963643002/diff/20001/components/cronet/stale...
components/cronet/stale_host_resolver_unittest.cc:87: mock_proc_(new
MockHostResolverProc()), resolver_(nullptr),
On 2017/06/27 22:50:11, pauljensen wrote:
> This indentation is wacky...I guess the formater has a bug...

Done.  Also merged and re-enabled tests.

[commit-bot: I haz the power, 2017-06-28 13:11:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 13:11:05]

Dry run: This issue passed the CQ dry run.

[pauljensen, 2017-06-28 13:28:43]

The CQ bit was checked by pauljensen@chromium.org

[pauljensen, 2017-06-28 13:28:43]

lgtm

[commit-bot: I haz the power, 2017-06-28 13:28:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 13:34:14]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498656523031140,
"parent_rev": "834321a24d546bfcb0ab4a2606c5e30cfa0ab7e2", "commit_rev":
"51629db1e4abd11d33150d7fc0a2207c0fc5cd9c"}

[commit-bot: I haz the power, 2017-06-28 13:34:27]

Description was changed from

==========
Fix Cronet tests.

These were broken when URLRequestContextBuilder was switched over to
using task_scheduler by default in
https://codereview.chromium.org/2951813002/.

The fix is to instantiate a base::test::ScopedTaskEnvironment instead
of a MessageLoopForIO.

BUG=715695,737326
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Fix Cronet tests.

These were broken when URLRequestContextBuilder was switched over to
using task_scheduler by default in
https://codereview.chromium.org/2951813002/.

The fix is to instantiate a base::test::ScopedTaskEnvironment instead
of a MessageLoopForIO.

BUG=715695,737326
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2963643002
Cr-Commit-Position: refs/heads/master@{#482965}
Committed:
https://chromium.googlesource.com/chromium/src/+/51629db1e4abd11d33150d7fc0a2...
==========

[commit-bot: I haz the power, 2017-06-28 13:34:28]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/51629db1e4abd11d33150d7fc0a2...