Remove special casing for context menu animation for BrowserActions.

Remove special casing for context menu animation for BrowserActions.

Instead of using a different animation type, generate "fake" touch
coordinates at the center of the screen to get the same result.

BUG=719080
Review-Url: https://codereview.chromium.org/2963583003
Cr-Commit-Position: refs/heads/master@{#482906}
Committed: https://chromium.googlesource.com/chromium/src/+/7df4d3a9181f7138fb7ea00c5a8bf51db6e8250a

[Ted C, 2017-06-27 18:48:56]

tedchoc@chromium.org changed reviewers:
+ ltian@chromium.org

[Ted C, 2017-06-27 18:48:57]

PTAL

[Theresa, 2017-06-27 20:05:32]

twellington@chromium.org changed reviewers:
+ twellington@chromium.org

[Theresa, 2017-06-27 20:05:33]

https://codereview.chromium.org/2963583003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionActivity.java
(right):

https://codereview.chromium.org/2963583003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionActivity.java:106:
getWindow().getDecorView().getWindowVisibleDisplayFrame(rect);
The JavaDoc for this says: "This function requires an IPC back to the window
manager to retrieve the requested information, so should not be used in
performance critical code like drawing."

You may be able to use WindowManager#getDefaultDisplay()#getSize() instead.
https://developer.android.com/reference/android/view/Display.html#getSize(and...

I didn't catch this in the initial context menu animation design, but we should
change ContextMenuDialog too

[Ted C, 2017-06-27 20:58:01]

https://codereview.chromium.org/2963583003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionActivity.java
(right):

https://codereview.chromium.org/2963583003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionActivity.java:106:
getWindow().getDecorView().getWindowVisibleDisplayFrame(rect);
On 2017/06/27 20:05:33, Theresa wrote:
> The JavaDoc for this says: "This function requires an IPC back to the window
> manager to retrieve the requested information, so should not be used in
> performance critical code like drawing."
> 
> You may be able to use WindowManager#getDefaultDisplay()#getSize() instead.
>
https://developer.android.com/reference/android/view/Display.html#getSize(and...
> 
> I didn't catch this in the initial context menu animation design, but we
should
> change ContextMenuDialog too

Done (didn't change ContextMenuDialog as I need to test keyboard interactions
and other stuff from the comment below).

We really need to get a handle on what situations should use one vs the other. 
We use getWindowVisibleDisplayFrame a bunch of places in the UI.  I printed the
dimens between the getSize and getWindowDisplayFrame and they return the same. 
I believe getWindowDisplayFrame will account for things like keyboard height,
where maybe getSize doesn't?

In general, I think we use these haphazardly in the code many places and we
likely should have some class that abstracts away the implementation and does
something consistent (i.e. something like DeviceSizeUtils).  Something for
another day.

[Theresa, 2017-06-27 20:59:42]

lgtm

[ltian, 2017-06-27 22:57:01]

On 2017/06/27 20:59:42, Theresa wrote:
> lgtm

lgtm

[Ted C, 2017-06-27 23:41:43]

The CQ bit was checked by tedchoc@chromium.org

[commit-bot: I haz the power, 2017-06-27 23:42:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 00:52:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 00:52:28]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Ted C, 2017-06-28 05:57:46]

The CQ bit was checked by tedchoc@chromium.org

[Ted C, 2017-06-28 05:57:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org, ltian@chromium.org
Link to the patchset: https://codereview.chromium.org/2963583003/#ps40001
(title: "Fix findbugs")

[commit-bot: I haz the power, 2017-06-28 05:58:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 06:51:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498629466636570,
"parent_rev": "19bd384f656790e8e409086b5b97a53b3a6f5921", "commit_rev":
"7df4d3a9181f7138fb7ea00c5a8bf51db6e8250a"}

[commit-bot: I haz the power, 2017-06-28 06:51:21]

Description was changed from

==========
Remove special casing for context menu animation for BrowserActions.

Instead of using a different animation type, generate "fake" touch
coordinates at the center of the screen to get the same result.

BUG=719080
==========

to

==========
Remove special casing for context menu animation for BrowserActions.

Instead of using a different animation type, generate "fake" touch
coordinates at the center of the screen to get the same result.

BUG=719080

Review-Url: https://codereview.chromium.org/2963583003
Cr-Commit-Position: refs/heads/master@{#482906}
Committed:
https://chromium.googlesource.com/chromium/src/+/7df4d3a9181f7138fb7ea00c5a8b...
==========

[commit-bot: I haz the power, 2017-06-28 06:51:22]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7df4d3a9181f7138fb7ea00c5a8b...