luci_config/server/cfgclient/resolver.go - Issue 2963503003: [errors] Greatly simplify common/errors package.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: luci_config/server/cfgclient/resolver.go

Issue 2963503003: [errors] Greatly simplify common/errors package. (Closed)

Patch Set: fix nits Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: luci_config/server/cfgclient/resolver.go

diff --git a/luci_config/server/cfgclient/resolver.go b/luci_config/server/cfgclient/resolver.go

index 657f5903a1e70ad8fe02031a536197422414c79f..248fa14a7bd212a71d9a26dfecb9732c10ac5e0a 100644

--- a/luci_config/server/cfgclient/resolver.go

+++ b/luci_config/server/cfgclient/resolver.go

@@ -50,7 +50,7 @@ type FormattingResolver interface {

func assertEmptyFormat(it *backend.Item) error {

if !it.FormatSpec.Unformatted() {

- return errors.Reason("unknown format: %(format)q").D("format", it.FormatSpec.Formatter).Err()

+ return errors.Reason("unknown format: %q", it.FormatSpec.Formatter).Err()

}

return nil

}