Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: luci_config/server/cfgclient/backend/get_all.go

Issue 2963503003: [errors] Greatly simplify common/errors package. (Closed)
Patch Set: fix nits Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « luci_config/server/cfgclient/backend/format/formatters.go ('k') | luci_config/server/cfgclient/resolver.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: luci_config/server/cfgclient/backend/get_all.go
diff --git a/luci_config/server/cfgclient/backend/get_all.go b/luci_config/server/cfgclient/backend/get_all.go
index a789e85dc3b785cf9fad6d92eaaa657562126622..3d5b156ffd952fe584c256925ce2313d7417f4b0 100644
--- a/luci_config/server/cfgclient/backend/get_all.go
+++ b/luci_config/server/cfgclient/backend/get_all.go
@@ -36,7 +36,7 @@ func (gat GetAllTarget) MarshalJSON() ([]byte, error) {
case GetAllRef:
return refJSON, nil
default:
- return nil, errors.Reason("unknown GetAllTarget: %(value)v").D("value", gat).Err()
+ return nil, errors.Reason("unknown GetAllTarget: %v", gat).Err()
}
}
@@ -48,7 +48,7 @@ func (gat *GetAllTarget) UnmarshalJSON(d []byte) error {
case bytes.Equal(d, refJSON):
*gat = GetAllRef
default:
- return errors.Reason("unknown GetAllTarget: %(value)q").D("value", d).Err()
+ return errors.Reason("unknown GetAllTarget: %q", d).Err()
}
return nil
}
« no previous file with comments | « luci_config/server/cfgclient/backend/format/formatters.go ('k') | luci_config/server/cfgclient/resolver.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698