Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Unified Diff: logdog/appengine/coordinator/endpoints/logs/get.go

Issue 2963503003: [errors] Greatly simplify common/errors package. (Closed)
Patch Set: fix nits Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « grpc/prpc/client.go ('k') | logdog/appengine/coordinator/service.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: logdog/appengine/coordinator/endpoints/logs/get.go
diff --git a/logdog/appengine/coordinator/endpoints/logs/get.go b/logdog/appengine/coordinator/endpoints/logs/get.go
index 64478d023c47b8e041cd8e74a602524d3834f325..0076835ae4a7dc94a4b44e297a69c383d101f558 100644
--- a/logdog/appengine/coordinator/endpoints/logs/get.go
+++ b/logdog/appengine/coordinator/endpoints/logs/get.go
@@ -140,7 +140,7 @@ func (s *server) getLogs(c context.Context, req *logdog.GetRequest, resp *logdog
svc := coordinator.GetServices(c)
st, err := svc.StorageForStream(c, lst)
if err != nil {
- return errors.Annotate(err).InternalReason("failed to create storage instance").Err()
+ return errors.Annotate(err, "").InternalReason("failed to create storage instance").Err()
}
defer st.Close()
@@ -166,7 +166,7 @@ func (s *server) getLogs(c context.Context, req *logdog.GetRequest, resp *logdog
signedURLs, err := st.GetSignedURLs(c, &signingRequest)
switch {
case err != nil:
- return errors.Annotate(err).InternalReason("failed to generate signed URL").Err()
+ return errors.Annotate(err, "").InternalReason("failed to generate signed URL").Err()
case signedURLs == nil:
log.Debugf(c, "Signed URL was requested, but is not supported by storage.")
« no previous file with comments | « grpc/prpc/client.go ('k') | logdog/appengine/coordinator/service.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698