grpc/prpc/client.go - Issue 2963503003: [errors] Greatly simplify common/errors package.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: grpc/prpc/client.go

Issue 2963503003: [errors] Greatly simplify common/errors package. (Closed)

Patch Set: fix nits Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: grpc/prpc/client.go

diff --git a/grpc/prpc/client.go b/grpc/prpc/client.go

index 971a8c01f6bae1d62769616e0c2aa11a7e234b92..d958196853179f0420a34661e89150446f3b3316 100644

--- a/grpc/prpc/client.go

+++ b/grpc/prpc/client.go

@@ -204,8 +204,7 @@ func (c *Client) CallRaw(ctx context.Context, serviceName, methodName string, in

}

if err != nil {

// Treat all errors here as transient.

- return errors.Annotate(err).Reason("failed to send request").

- Tag(transient.Tag).Err()

+ return errors.Annotate(err, "failed to send request").Tag(transient.Tag).Err()

}

if options.resHeaderMetadata != nil {

« no previous file with comments | « grpc/grpcutil/errors.go ('k') | logdog/appengine/coordinator/endpoints/logs/get.go » ('j') | no next file with comments »