dm/appengine/mutate/timeout_execution.go - Issue 2963503003: [errors] Greatly simplify common/errors package.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dm/appengine/mutate/timeout_execution.go

Issue 2963503003: [errors] Greatly simplify common/errors package. (Closed)

Patch Set: fix nits Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dm/appengine/mutate/timeout_execution.go

diff --git a/dm/appengine/mutate/timeout_execution.go b/dm/appengine/mutate/timeout_execution.go

index 15c9a126a99d022906a4098cf83327fbe6cfc961..6fbc6407b450e61ffba6189980696fe94bbf8249 100644

--- a/dm/appengine/mutate/timeout_execution.go

+++ b/dm/appengine/mutate/timeout_execution.go

@@ -87,7 +87,7 @@ func (t *TimeoutExecution) RollForward(c context.Context) (muts []tumble.Mutatio

var realRslt *dm.Result

q := model.QuestFromID(t.For.Quest)

if err = ds.Get(ds.WithoutTransaction(c), q); err != nil {

- err = errors.Annotate(err).Reason("loading quest").Err()

+ err = errors.Annotate(err, "loading quest").Err()

return

}

realRslt, err = dist.GetStatus(&q.Desc, distributor.Token(e.DistributorToken))

« no previous file with comments | « dm/appengine/mutate/finish_attempt.go ('k') | dm/tools/dmtool/vizQuery.go » ('j') | no next file with comments »