dm/appengine/mutate/finish_attempt.go - Issue 2963503003: [errors] Greatly simplify common/errors package.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dm/appengine/mutate/finish_attempt.go

Issue 2963503003: [errors] Greatly simplify common/errors package. (Closed)

Patch Set: fix nits Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dm/appengine/mutate/finish_attempt.go

diff --git a/dm/appengine/mutate/finish_attempt.go b/dm/appengine/mutate/finish_attempt.go

index ba1ee13012d596690c54b2f967988ec9b33be899..0ccfd8f508ea752cd7d1a64fd5c24b973ae18330 100644

--- a/dm/appengine/mutate/finish_attempt.go

+++ b/dm/appengine/mutate/finish_attempt.go

@@ -55,8 +55,7 @@ func (f *FinishAttempt) RollForward(c context.Context) (muts []tumble.Mutation,

atmpt.Result.Data = &rslt

atmpt.Result.Data.Object = ""

- err = errors.Annotate(ds.Put(c, atmpt, ar)).Tag(grpcutil.Tag.With(codes.Internal)).

- Reason("during Put").Err()

+ err = errors.Annotate(ds.Put(c, atmpt, ar), "during Put").Tag(grpcutil.Tag.With(codes.Internal)).Err()

return

}

« no previous file with comments | « dm/appengine/mutate/add_deps.go ('k') | dm/appengine/mutate/timeout_execution.go » ('j') | no next file with comments »