Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: dm/appengine/mutate/add_deps.go

Issue 2963503003: [errors] Greatly simplify common/errors package. (Closed)
Patch Set: fix nits Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dm/appengine/distributor/swarming/v1/isolate.go ('k') | dm/appengine/mutate/finish_attempt.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/appengine/mutate/add_deps.go
diff --git a/dm/appengine/mutate/add_deps.go b/dm/appengine/mutate/add_deps.go
index 0645ffa03e3d28b568ec25c095f140eec7fcb669..5f34cec4d0898de96b1f1ee72857753627c9c165 100644
--- a/dm/appengine/mutate/add_deps.go
+++ b/dm/appengine/mutate/add_deps.go
@@ -51,8 +51,7 @@ func (a *AddDeps) RollForward(c context.Context) (muts []tumble.Mutation, err er
}
fwdDeps, err := filterExisting(c, model.FwdDepsFromList(c, a.Auth.Id.AttemptID(), a.Deps))
- err = errors.Annotate(err).Tag(grpcutil.Tag.With(codes.Internal)).
- Reason("while filtering deps").Err()
+ err = errors.Annotate(err, "while filtering deps").Tag(grpcutil.Tag.With(codes.Internal)).Err()
if err != nil || len(fwdDeps) == 0 {
return
}
@@ -66,8 +65,7 @@ func (a *AddDeps) RollForward(c context.Context) (muts []tumble.Mutation, err er
}
if err = ds.Put(c, fwdDeps, atmpt, ex); err != nil {
- err = errors.Annotate(err).Tag(grpcutil.Tag.With(codes.Internal)).
- Reason("putting stuff").Err()
+ err = errors.Annotate(err, "putting stuff").Tag(grpcutil.Tag.With(codes.Internal)).Err()
return
}
« no previous file with comments | « dm/appengine/distributor/swarming/v1/isolate.go ('k') | dm/appengine/mutate/finish_attempt.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698