Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Unified Diff: dm/appengine/deps/auth.go

Issue 2963503003: [errors] Greatly simplify common/errors package. (Closed)
Patch Set: fix nits Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « deploytool/managedfs/util.go ('k') | dm/appengine/deps/ensure_graph_data.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/appengine/deps/auth.go
diff --git a/dm/appengine/deps/auth.go b/dm/appengine/deps/auth.go
index 4aca54a9bdad552901323ea02063d7d1b230617c..a721b164196b4e591acabfedfa9c2f29cf5b6c73 100644
--- a/dm/appengine/deps/auth.go
+++ b/dm/appengine/deps/auth.go
@@ -24,8 +24,8 @@ func loadAcls(c context.Context) (ret *acls.Acls, err error) {
ret = &acls.Acls{}
if err := cfgclient.Get(c, cfgclient.AsService, cSet, file, textproto.Message(ret), nil); err != nil {
- return nil, errors.Annotate(err).Tag(transient.Tag).
- D("cSet", cSet).D("file", file).InternalReason("loading config").Err()
+ return nil, errors.Annotate(err, "").Tag(transient.Tag).
+ InternalReason("loading config :: cSet(%v)/file(%v)", cSet, file).Err()
}
return
}
@@ -34,7 +34,7 @@ func inGroups(c context.Context, groups []string) error {
for _, grp := range groups {
ok, err := auth.IsMember(c, grp)
if err != nil {
- return grpcAnnotate(err, codes.Internal).Reason("failed group check").Err()
+ return grpcAnnotate(err, codes.Internal, "failed group check").Err()
}
if ok {
return nil
« no previous file with comments | « deploytool/managedfs/util.go ('k') | dm/appengine/deps/ensure_graph_data.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698