Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: deploytool/managedfs/util.go

Issue 2963503003: [errors] Greatly simplify common/errors package. (Closed)
Patch Set: fix nits Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « deploytool/managedfs/filesystem.go ('k') | dm/appengine/deps/auth.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: deploytool/managedfs/util.go
diff --git a/deploytool/managedfs/util.go b/deploytool/managedfs/util.go
index b93fab82271f3b15263f69701089c0166d8d8cba..08424acfe16043c65a7be61256972624a3d65d96 100644
--- a/deploytool/managedfs/util.go
+++ b/deploytool/managedfs/util.go
@@ -16,7 +16,7 @@ import (
func ensureDirectory(path string) error {
if err := os.MkdirAll(path, 0755); err != nil {
- return errors.Annotate(err).Reason("failed to create directory [%(path)s]").D("path", path).Err()
+ return errors.Annotate(err, "failed to create directory [%s]", path).Err()
}
return nil
}
@@ -32,15 +32,15 @@ func createFile(path string) (*os.File, error) {
break
case err != nil:
- return nil, errors.Annotate(err).Reason("failed to lstat [%(path)s]").D("path", path).Err()
+ return nil, errors.Annotate(err, "failed to lstat [%s]", path).Err()
case st.IsDir():
- return nil, errors.Reason("cannot create; path [%(path)s] is a directory").D("path", path).Err()
+ return nil, errors.Reason("cannot create; path [%s] is a directory", path).Err()
default:
// Exists, and is a file/link, so unlink.
if err := os.Remove(path); err != nil {
- return nil, errors.Annotate(err).Reason("failed to remove existing [%(path)s]").D("path", path).Err()
+ return nil, errors.Annotate(err, "failed to remove existing [%s]", path).Err()
}
}
@@ -76,7 +76,7 @@ func byteCompare(a, b io.Reader, aBuf, bBuf []byte) (bool, error) {
ac, err := a.Read(aBuf)
if err != nil {
if err != io.EOF {
- return false, errors.Annotate(err).Reason("failed to read").Err()
+ return false, errors.Annotate(err, "failed to read").Err()
}
ac = 0
done = true
@@ -85,7 +85,7 @@ func byteCompare(a, b io.Reader, aBuf, bBuf []byte) (bool, error) {
bc, err := b.Read(bBuf)
if err != nil {
if err != io.EOF {
- return false, errors.Annotate(err).Reason("failed to read").Err()
+ return false, errors.Annotate(err, "failed to read").Err()
}
bc = 0
}
« no previous file with comments | « deploytool/managedfs/filesystem.go ('k') | dm/appengine/deps/auth.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698