Convert {angle,gl}_unittests to using console_test_launcher.

Convert {angle,gl}_unittests to using console_test_launcher.

Because these tests require direct GPU access, we need to disable
xvfb by passing --no-xvfb to the test launcher.

BUG=732652
R=dpranke@chromium.org,kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2963473002
Cr-Commit-Position: refs/heads/master@{#483773}
Committed: https://chromium.googlesource.com/chromium/src/+/381297ba9393173f1aa477784f3c6b58cf325216

[pcc1, 2017-06-26 23:28:39]

Description was changed from

==========
Convert {angle,gl}_unittests to using console_test_launcher.

Because these tests require direct GPU access, we need to disable
xvfb by passing --no-xvfb to the test launcher.

BUG=732652
R=dpranke@chromium.org,kbr@chromium.org
==========

to

==========
Convert {angle,gl}_unittests to using console_test_launcher.

Because these tests require direct GPU access, we need to disable
xvfb by passing --no-xvfb to the test launcher.

BUG=732652
R=dpranke@chromium.org,kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[pcc1, 2017-06-26 23:30:43]

The CQ bit was checked by pcc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-26 23:30:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 02:18:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-27 02:18:11]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Russell (switch to Gerrit), 2017-06-27 21:30:45]

The linux_chromium_asan_rel_ng failures look real. I filed
https://bugs.chromium.org/p/angleproject/issues/detail?id=2094 about them.

I can reproduce them locally. Not sure why they are only showing up now.

[Ken Russell (switch to Gerrit), 2017-06-27 21:42:31]

The memory leaks are being fixed in
https://chromium-review.googlesource.com/550569 . I think we need to wait for
that to land and roll forward ANGLE before proceeding with this CL.

[pcc1, 2017-06-27 21:43:51]

SGTM, thanks.

[Dirk Pranke, 2017-06-29 23:59:42]

lgtm

[pcc1, 2017-06-30 17:17:05]

The CQ bit was checked by pcc@chromium.org

[commit-bot: I haz the power, 2017-06-30 17:17:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 17:24:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-30 17:24:33]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pcc1, 2017-06-30 17:28:44]

kbr@: ptal, looks like the roll has happened now.

[Ken Russell (switch to Gerrit), 2017-06-30 18:29:02]

lgtm

Thanks for fixing this and waiting until the underlying tests were fixed.

[pcc1, 2017-06-30 18:29:35]

The CQ bit was checked by pcc@chromium.org

[commit-bot: I haz the power, 2017-06-30 18:29:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 18:37:09]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498847375105540, "parent_rev":
"904f82feaaf91128033fea4637a994c37b59a084", "commit_rev":
"381297ba9393173f1aa477784f3c6b58cf325216"}

[commit-bot: I haz the power, 2017-06-30 18:37:27]

Description was changed from

==========
Convert {angle,gl}_unittests to using console_test_launcher.

Because these tests require direct GPU access, we need to disable
xvfb by passing --no-xvfb to the test launcher.

BUG=732652
R=dpranke@chromium.org,kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Convert {angle,gl}_unittests to using console_test_launcher.

Because these tests require direct GPU access, we need to disable
xvfb by passing --no-xvfb to the test launcher.

BUG=732652
R=dpranke@chromium.org,kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2963473002
Cr-Commit-Position: refs/heads/master@{#483773}
Committed:
https://chromium.googlesource.com/chromium/src/+/381297ba9393173f1aa477784f3c...
==========

[commit-bot: I haz the power, 2017-06-30 18:37:28]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/381297ba9393173f1aa477784f3c...