Add ability to select all using keyboard (Ctrl+A) in PDF forms.

Add ability to select all using keyboard (Ctrl+A) in PDF forms.

Changed code so that when Ctrl+A is pressed while focus is in a form
text area, all of the text within the form text area is selected (and
the regular text outside of the form text area is ignored).

Review-Url: https://codereview.chromium.org/2963413002
Cr-Commit-Position: refs/heads/master@{#484805}
Committed: https://chromium.googlesource.com/chromium/src/+/d1cac1607eec59540a09a37d227d560408e89be0

[drgage, 2017-07-01 01:30:57]

Description was changed from

==========
Add ability to select all using keyboard (Ctrl+A) in PDF forms.

Changed code so that when Ctrl+A is pressed while focus is in a form
text area, all of the text within the form text area is selected (and
the regular text outside of the form text area is ignored).
==========

to

==========
Add ability to select all using keyboard (Ctrl+A) in PDF forms.

Changed code so that when Ctrl+A is pressed while focus is in a form
text area, all of the text within the form text area is selected (and
the regular text outside of the form text area is ignored).
==========

[drgage, 2017-07-01 01:30:57]

drgage@google.com changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[drgage, 2017-07-01 01:33:15]

Hi Lei and Dan,

In this CL, I changed a few lines so that when a user selects all the text in a
form text area via CTRL+A, the behavior is as expected. Previously, when this
action was performed, all of the text on the PDF was selected (not just what was
in the form text area).

If we want to edit the context menu so that a "Select All" option appears, that
will involve more work, but this functionality is working with the keyboard for
now.

Thanks for reviewing.

Best,
Diana

[Lei Zhang, 2017-07-05 22:33:21]

lgtm

This is fine for now. I just filed https://crbug.com/739529 to discuss the
situation here. Since the call to PDFiumEngine::SelectAll() comes from JS
keyboard handling code, and JS also knows whether we are in a form field or not.
So potentially the JS code could decide to do a similar check there and not
bother calling SelectAll() in the first place.

[drgage, 2017-07-06 22:25:36]

The CQ bit was checked by drgage@google.com

[drgage, 2017-07-06 22:25:37]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2963413002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-07-06 22:25:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 22:38:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-06 22:38:53]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[drgage, 2017-07-06 23:50:55]

The CQ bit was checked by drgage@google.com

[commit-bot: I haz the power, 2017-07-06 23:51:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-07 01:30:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-07 01:30:22]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Lei Zhang, 2017-07-07 01:53:40]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2017-07-07 01:53:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-07 02:35:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499392420875230,
"parent_rev": "cfcca5d50f371e7c5784be5f0ac39acd7664b513", "commit_rev":
"d1cac1607eec59540a09a37d227d560408e89be0"}

[commit-bot: I haz the power, 2017-07-07 02:35:51]

Description was changed from

==========
Add ability to select all using keyboard (Ctrl+A) in PDF forms.

Changed code so that when Ctrl+A is pressed while focus is in a form
text area, all of the text within the form text area is selected (and
the regular text outside of the form text area is ignored).
==========

to

==========
Add ability to select all using keyboard (Ctrl+A) in PDF forms.

Changed code so that when Ctrl+A is pressed while focus is in a form
text area, all of the text within the form text area is selected (and
the regular text outside of the form text area is ignored).

Review-Url: https://codereview.chromium.org/2963413002
Cr-Commit-Position: refs/heads/master@{#484805}
Committed:
https://chromium.googlesource.com/chromium/src/+/d1cac1607eec59540a09a37d227d...
==========

[commit-bot: I haz the power, 2017-07-07 02:35:52]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d1cac1607eec59540a09a37d227d...