Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2963333002: MD Settings: fix side-menu items not visible. (Closed)

Created:
3 years, 5 months ago by scottchen
Modified:
3 years, 5 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: fix side-menu items not visible. BUG=738319 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2963333002 Cr-Commit-Position: refs/heads/master@{#483868} Committed: https://chromium.googlesource.com/chromium/src/+/eab1ead9ca6429ab9c7f6614f3f97780857a43d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/page_visibility.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
scottchen
3 years, 5 months ago (2017-06-30 18:31:24 UTC) #5
dpapad
LGTMing this so that the regression is fixed. We should investigate why no test broke ...
3 years, 5 months ago (2017-06-30 18:34:02 UTC) #6
dpapad
LGTM
3 years, 5 months ago (2017-06-30 23:10:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2963333002/1
3 years, 5 months ago (2017-06-30 23:57:55 UTC) #11
commit-bot: I haz the power
3 years, 5 months ago (2017-07-01 00:02:12 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eab1ead9ca6429ab9c7f6614f3f9...

Powered by Google App Engine
This is Rietveld 408576698