Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Unified Diff: pkg/analysis_server/test/domain_server_test.dart

Issue 2963323002: Add analytics to analyzer-cli and analysis server. (Closed)
Patch Set: suppress analytics for integration tests; update the gn files Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/domain_server_test.dart
diff --git a/pkg/analysis_server/test/domain_server_test.dart b/pkg/analysis_server/test/domain_server_test.dart
index b0aee98343b5ae346f7465ef7c03faff560ed839..183836d021b03eb0dfefcdb4ede19485caaa7512 100644
--- a/pkg/analysis_server/test/domain_server_test.dart
+++ b/pkg/analysis_server/test/domain_server_test.dart
@@ -2,6 +2,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
+import 'dart:async';
+
import 'package:analysis_server/protocol/protocol.dart';
import 'package:analysis_server/protocol/protocol_constants.dart';
import 'package:analysis_server/protocol/protocol_generated.dart';
@@ -32,7 +34,7 @@ main() {
resourceProvider,
new MockPackageMapProvider(),
serverPlugin,
- new AnalysisServerOptions(),
+ new AnalysisServerOptions()..addMocks(),
new DartSdkManager('', false),
InstrumentationService.NULL_SERVICE);
handler = new ServerDomainHandler(server);
@@ -72,12 +74,16 @@ main() {
});
});
- test('shutdown', () {
+ test('shutdown', () async {
expect(server.running, isTrue);
// send request
var request = new ServerShutdownParams().toRequest('0');
var response = handler.handleRequest(request);
expect(response, isResponseSuccess('0'));
+
+ // delay a bit
+ await new Future.delayed(new Duration(seconds: 1));
scheglov 2017/06/30 23:36:30 Please don't add unconditional delays. We run thes
devoncarew 2017/07/01 22:18:05 This has been re-worked to not use a delay.
+
// server is down
expect(server.running, isFalse);
});

Powered by Google App Engine
This is Rietveld 408576698