pkg/analysis_server/test/integration/support/integration_tests.dart - Issue 2963323002: Add analytics to analyzer-cli and analysis server.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/integration/support/integration_tests.dart

Issue 2963323002: Add analytics to analyzer-cli and analysis server. (Closed)

Patch Set: suppress analytics for integration tests; update the gn files Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analysis_server/test/domain_server_test.dart ('K') | « pkg/analysis_server/test/domain_server_test.dart ('k') | pkg/analysis_server/test/socket_server_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/integration/support/integration_tests.dart

diff --git a/pkg/analysis_server/test/integration/support/integration_tests.dart b/pkg/analysis_server/test/integration/support/integration_tests.dart

index 1ce540c7ba2cdada86bd0ad59c940bae99007253..972e27ee2c49eed7d91eeeeb5fa9535b9293b0d6 100644

--- a/pkg/analysis_server/test/integration/support/integration_tests.dart

+++ b/pkg/analysis_server/test/integration/support/integration_tests.dart

@@ -694,6 +694,7 @@ class Server {

// Add server arguments.

+ arguments.add('--suppress-analytics');

if (diagnosticPort != null) {

arguments.add('--port');

arguments.add(diagnosticPort.toString());

@@ -707,11 +708,9 @@ class Server {

if (useAnalysisHighlight2) {

arguments.add('--useAnalysisHighlight2');

}

-// print('Launching $serverPath');

-// print('$dartBinary ${arguments.join(' ')}');

// TODO(devoncarew): We could experiment with instead launching the analysis

// server in a separate isolate. This would make it easier to debug the

- // integration tests, and would likely speed the tests up as well.

+ // integration tests, and would likely speed up the tests as well.

_process = await Process.start(dartBinary, arguments);

_process.exitCode.then((int code) {

if (code != 0) {