Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2963173004: document.registerElement() rejects a valid unregistered type with U+212A. (Closed)

Created:
3 years, 5 months ago by nikhil.sahni
Modified:
3 years, 5 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

document.registerElement() rejects a valid unregistered type with U+212A. RegisterElement rejects a valid type due to wrong usage of DeprecatedLower for register and should use LowerASCII instead of that. BUG=737879 Review-Url: https://codereview.chromium.org/2963173004 Cr-Commit-Position: refs/heads/master@{#484508} Committed: https://chromium.googlesource.com/chromium/src/+/07ee4ee6fbef420a23efcf927830b2eb6931f46b

Patch Set 1 #

Patch Set 2 : Added test case for this change #

Patch Set 3 : Correcting Indentation #

Patch Set 4 : Rebased the patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/dom/custom/register-element-with-U212A.html View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/custom/V0CustomElementRegistry.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 33 (20 generated)
Srirama
Peer review is fine, starting dry run.
3 years, 5 months ago (2017-06-30 09:23:56 UTC) #3
Shanmuga Pandi
I suggest to use gerrit for review.
3 years, 5 months ago (2017-06-30 09:29:17 UTC) #6
nikhil.sahni
On 2017/06/30 09:29:17, Shanmuga Pandi wrote: > I suggest to use gerrit for review. yes ...
3 years, 5 months ago (2017-06-30 11:13:45 UTC) #15
nikhil.sahni
On 2017/06/30 09:29:17, Shanmuga Pandi wrote: > I suggest to use gerrit for review. yes ...
3 years, 5 months ago (2017-06-30 11:13:45 UTC) #16
tkent
This CL needs a test.
3 years, 5 months ago (2017-07-03 00:12:12 UTC) #17
nikhil.sahni
Added test case for this. Thanks !!
3 years, 5 months ago (2017-07-05 09:57:01 UTC) #18
tkent
lgtm
3 years, 5 months ago (2017-07-05 23:01:35 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2963173004/40001
3 years, 5 months ago (2017-07-05 23:02:12 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/251944)
3 years, 5 months ago (2017-07-05 23:05:00 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2963173004/60001
3 years, 5 months ago (2017-07-06 05:15:25 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/421747)
3 years, 5 months ago (2017-07-06 06:23:06 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2963173004/60001
3 years, 5 months ago (2017-07-06 09:06:04 UTC) #30
commit-bot: I haz the power
3 years, 5 months ago (2017-07-06 09:12:32 UTC) #33
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/07ee4ee6fbef420a23efcf927830...

Powered by Google App Engine
This is Rietveld 408576698