|
|
Created:
3 years, 5 months ago by nikhil.sahni Modified:
3 years, 5 months ago CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Descriptiondocument.registerElement() rejects a valid unregistered type with U+212A.
RegisterElement rejects a valid type due to wrong
usage of DeprecatedLower for register and
should use LowerASCII instead of that.
BUG=737879
Review-Url: https://codereview.chromium.org/2963173004
Cr-Commit-Position: refs/heads/master@{#484508}
Committed: https://chromium.googlesource.com/chromium/src/+/07ee4ee6fbef420a23efcf927830b2eb6931f46b
Patch Set 1 #Patch Set 2 : Added test case for this change #Patch Set 3 : Correcting Indentation #Patch Set 4 : Rebased the patch #
Messages
Total messages: 33 (20 generated)
Description was changed from ========== document.registerElement() rejects a valid unregistered type with U+212A. RegisterElement rejects a valid type due to wrong usage of DeprecatedLower for register and should use LowerASCII instead of that. BUG=737879 ========== to ========== document.registerElement() rejects a valid unregistered type with U+212A. RegisterElement rejects a valid type due to wrong usage of DeprecatedLower for register and should use LowerASCII instead of that. BUG=737879 R=SamsungPeerReview ==========
nikhil.sahni@samsung.com changed reviewers: + shanmuga.m@samsung.com, srirama.m@samsung.com
Peer review is fine, starting dry run.
The CQ bit was checked by srirama.m@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
I suggest to use gerrit for review.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== document.registerElement() rejects a valid unregistered type with U+212A. RegisterElement rejects a valid type due to wrong usage of DeprecatedLower for register and should use LowerASCII instead of that. BUG=737879 R=SamsungPeerReview ========== to ========== document.registerElement() rejects a valid unregistered type with U+212A. RegisterElement rejects a valid type due to wrong usage of DeprecatedLower for register and should use LowerASCII instead of that. BUG=737879 ==========
nikhil.sahni@samsung.com changed reviewers: + tkent@chromium.org
Description was changed from ========== document.registerElement() rejects a valid unregistered type with U+212A. RegisterElement rejects a valid type due to wrong usage of DeprecatedLower for register and should use LowerASCII instead of that. BUG=737879 R=SamsungPeerReview ========== to ========== document.registerElement() rejects a valid unregistered type with U+212A. RegisterElement rejects a valid type due to wrong usage of DeprecatedLower for register and should use LowerASCII instead of that. BUG=737879 ==========
Description was changed from ========== document.registerElement() rejects a valid unregistered type with U+212A. RegisterElement rejects a valid type due to wrong usage of DeprecatedLower for register and should use LowerASCII instead of that. BUG=737879 R=SamsungPeerReview ========== to ========== document.registerElement() rejects a valid unregistered type with U+212A. RegisterElement rejects a valid type due to wrong usage of DeprecatedLower for register and should use LowerASCII instead of that. BUG=737879 ==========
nikhil.sahni@samsung.com changed reviewers: + tkent@chromium.org
nikhil.sahni@samsung.com changed reviewers: + tkent@chromium.org
On 2017/06/30 09:29:17, Shanmuga Pandi wrote: > I suggest to use gerrit for review. yes Shanmuga ,thanks for pointing out ,I will take care for that.
On 2017/06/30 09:29:17, Shanmuga Pandi wrote: > I suggest to use gerrit for review. yes Shanmuga ,thanks for pointing out ,I will take care for that.
This CL needs a test.
Added test case for this. Thanks !!
The CQ bit was checked by tkent@chromium.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by srirama.m@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org Link to the patchset: https://codereview.chromium.org/2963173004/#ps60001 (title: "Rebased the patch")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by nikhil.sahni@samsung.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 60001, "attempt_start_ts": 1499331950468970, "parent_rev": "87340af883f06c363febe752245c1ab1a926a234", "commit_rev": "07ee4ee6fbef420a23efcf927830b2eb6931f46b"}
Message was sent while issue was closed.
Description was changed from ========== document.registerElement() rejects a valid unregistered type with U+212A. RegisterElement rejects a valid type due to wrong usage of DeprecatedLower for register and should use LowerASCII instead of that. BUG=737879 ========== to ========== document.registerElement() rejects a valid unregistered type with U+212A. RegisterElement rejects a valid type due to wrong usage of DeprecatedLower for register and should use LowerASCII instead of that. BUG=737879 Review-Url: https://codereview.chromium.org/2963173004 Cr-Commit-Position: refs/heads/master@{#484508} Committed: https://chromium.googlesource.com/chromium/src/+/07ee4ee6fbef420a23efcf927830... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/07ee4ee6fbef420a23efcf927830... |