Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2963173003: Remove the cups_print_job_manager_impl header (Closed)

Created:
3 years, 5 months ago by skau
Modified:
3 years, 5 months ago
Reviewers:
Carlson, xdai1
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the cups_print_job_manager_impl header The header can be merged with the implementation. Removing the extra file will result in a little less maintenance. This is a pure refactor. No code was changed. BUG=734280 Review-Url: https://codereview.chromium.org/2963173003 Cr-Commit-Position: refs/heads/master@{#486526} Committed: https://chromium.googlesource.com/chromium/src/+/ecfb7892e75a1da32e60b9ca812066b7e18d81bb

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+293 lines, -366 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/chromeos/printing/cups_print_job_manager_impl.h View 1 chunk +0 lines, -121 lines 0 comments Download
M chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc View 1 2 chunks +293 lines, -244 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (9 generated)
skau
Unfortunately, gerrit diffs are not very friendly to large whitespace changes.
3 years, 5 months ago (2017-06-30 00:22:31 UTC) #2
Carlson
lgtm No idea how I missed this review, sorry about that.
3 years, 5 months ago (2017-07-12 00:33:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2963173003/20001
3 years, 5 months ago (2017-07-12 00:46:00 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 5 months ago (2017-07-12 00:46:02 UTC) #7
skau
xdai@: Can you approve as a committer?
3 years, 5 months ago (2017-07-12 00:46:37 UTC) #9
xdai1
On 2017/07/12 00:46:37, skau wrote: > xdai@: Can you approve as a committer? lgtm
3 years, 5 months ago (2017-07-13 17:12:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2963173003/20001
3 years, 5 months ago (2017-07-13 17:24:00 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/337710)
3 years, 5 months ago (2017-07-13 20:37:31 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2963173003/20001
3 years, 5 months ago (2017-07-13 20:39:36 UTC) #16
commit-bot: I haz the power
3 years, 5 months ago (2017-07-13 23:27:08 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ecfb7892e75a1da32e60b9ca8120...

Powered by Google App Engine
This is Rietveld 408576698