Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2963113002:
Introduce Selection#compute{Left,Top} in assert_selection() (Closed)
|
Created:
3 years, 5 months ago by yosin_UTC9 Modified:
3 years, 5 months ago CC:
blink-reviews, chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionIntroduce Selection#compute{Left,Top} in assert_selection()
This patch Introduces |selection#compute{Left,Top}| in |assert_selection()|
to provide left and top position for mouse click testing.
This patch is a preparation of the patch[1].
[1] http://crrev.com/2966473002: Convert editing/selection/shift-click.html to use
assert_selection()
BUG=679977
TEST=n/a; no behavior changes
Review-Url: https://codereview.chromium.org/2963113002
Cr-Commit-Position: refs/heads/master@{#483929}
Committed: https://chromium.googlesource.com/chromium/src/+/34addba369d69ea62337a995e89328c0cca05665
Patch Set 1 : 2017-06-29T15:20:58 #
Total comments: 2
Patch Set 2 : 2017-06-29T17:38:54 #
Total comments: 2
Patch Set 3 : 2017-06-30T17:20:04 #
Dependent Patchsets: Messages
Total messages: 35 (27 generated)
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Patchset #1 (id:1) has been deleted
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Patchset #1 (id:20001) has been deleted
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Patchset #1 (id:40001) has been deleted
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from
==========
2017-06-29T14:20:34
BUG=679977
2017-06-29T14:20:29
==========
to
==========
Introduce Selection#compute{Left,Top} in assert_selection()
This patch Introduces |selection#compute{Left,Top}| in |assert_selection()|
to provide left and top position for mouse click testing.
BUG=679977
TEST=n/a; no behavior changes
==========
Description was changed from
==========
Introduce Selection#compute{Left,Top} in assert_selection()
This patch Introduces |selection#compute{Left,Top}| in |assert_selection()|
to provide left and top position for mouse click testing.
BUG=679977
TEST=n/a; no behavior changes
==========
to
==========
Introduce Selection#compute{Left,Top} in assert_selection()
This patch Introduces |selection#compute{Left,Top}| in |assert_selection()|
to provide left and top position for mouse click testing.
This patch is a preparation of the patch[1].
[1] http://crrev.com/2966473002: Convert editing/selection/shift-click.html to
use
assert_selection()
BUG=679977
TEST=n/a; no behavior changes
==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
yosin@chromium.org changed reviewers: + xiaochengh@chromium.org, yoichio@chromium.org
PTAL win_chromimum_rel_ng bot failure doesn't relate tot this patch. It is compilation error...
https://codereview.chromium.org/2963113002/diff/60001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/editing/assert_selection.html (right): https://codereview.chromium.org/2963113002/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/editing/assert_selection.html:367: '<div id="first">one <span id="start"></span>two three</div>', We miss cursors in expect.
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL Updated expectation and fix offsets. https://codereview.chromium.org/2963113002/diff/60001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/editing/assert_selection.html (right): https://codereview.chromium.org/2963113002/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/editing/assert_selection.html:367: '<div id="first">one <span id="start"></span>two three</div>', On 2017/06/29 at 08:09:35, yoichio wrote: > We miss cursors in expect. Oops, I forgot to update.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2963113002/diff/80001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/editing/assert_selection.js (right): https://codereview.chromium.org/2963113002/diff/80001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/editing/assert_selection.js:63: // Offset adjustment for mouse clicking used in |compute{Left,Top}()|. Why do you need this adjustment?
PTAL Changed to explain about constant value. It is border-size of IFRAME. https://codereview.chromium.org/2963113002/diff/80001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/editing/assert_selection.js (right): https://codereview.chromium.org/2963113002/diff/80001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/editing/assert_selection.js:63: // Offset adjustment for mouse clicking used in |compute{Left,Top}()|. On 2017/06/30 at 01:45:59, yoichio wrote: > Why do you need this adjustment? This value should be 2. It is border-size comes from html.css as iframe { border: 2px inset }
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1499047093824420,
"parent_rev": "426f46f231759c646bf2357be299f87d2c966260", "commit_rev":
"34addba369d69ea62337a995e89328c0cca05665"}
Message was sent while issue was closed.
Description was changed from
==========
Introduce Selection#compute{Left,Top} in assert_selection()
This patch Introduces |selection#compute{Left,Top}| in |assert_selection()|
to provide left and top position for mouse click testing.
This patch is a preparation of the patch[1].
[1] http://crrev.com/2966473002: Convert editing/selection/shift-click.html to
use
assert_selection()
BUG=679977
TEST=n/a; no behavior changes
==========
to
==========
Introduce Selection#compute{Left,Top} in assert_selection()
This patch Introduces |selection#compute{Left,Top}| in |assert_selection()|
to provide left and top position for mouse click testing.
This patch is a preparation of the patch[1].
[1] http://crrev.com/2966473002: Convert editing/selection/shift-click.html to
use
assert_selection()
BUG=679977
TEST=n/a; no behavior changes
Review-Url: https://codereview.chromium.org/2963113002
Cr-Commit-Position: refs/heads/master@{#483929}
Committed:
https://chromium.googlesource.com/chromium/src/+/34addba369d69ea62337a995e893...
==========
Message was sent while issue was closed.
Committed patchset #3 (id:100001) as https://chromium.googlesource.com/chromium/src/+/34addba369d69ea62337a995e893... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
