Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2963063002: Removing NackPackets from gfe/quic/core/quic_connection_test.cc Removing the Remove functions from … (Closed)

Created:
3 years, 5 months ago by wangyix1
Modified:
3 years, 5 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing NackPackets from gfe/quic/core/quic_connection_test.cc Removing the Remove functions from gfe/quic/core/frames/quic_ack_frame Merge internal change: 159953097 R=rch@chromium.org

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -71 lines) Patch
M net/quic/core/frames/quic_ack_frame.h View 1 chunk +0 lines, -7 lines 0 comments Download
M net/quic/core/frames/quic_ack_frame.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M net/quic/core/quic_connection_test.cc View 1 26 chunks +64 lines, -56 lines 0 comments Download

Depends on Patchset:

Issue 2962773003 Patch 60001

Dependent Patchsets:

Issue 2959373002 Patch 20001

Messages

Total messages: 10 (8 generated)
wangyix1
3 years, 5 months ago (2017-06-29 00:34:34 UTC) #1
Ryan Hamilton
3 years, 5 months ago (2017-06-29 02:53:34 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698