Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2963053002: Drop custom dart_host_sdk used for Flutter. (Closed)

Created:
3 years, 5 months ago by aam
Modified:
3 years, 5 months ago
Reviewers:
zra, rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org, zra
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Drop custom dart_host_sdk used for Flutter. Instead have Flutter fetch prebuilt host sdk into same location where standalone dart expects it. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/501688de4cb6ba62a5bfe655361edf122cc1d7fc

Patch Set 1 #

Patch Set 2 : Remove the flag from tools/gn.py #

Patch Set 3 : Merge branch 'master' of github.com:dart-lang/sdk into drop_custom_dart_host_pub #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -37 lines) Patch
M runtime/observatory/BUILD.gn View 1 chunk +1 line, -32 lines 0 comments Download
M tools/gn.py View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
aam
3 years, 5 months ago (2017-06-28 23:56:57 UTC) #2
aam
This is a prerequisite for https://github.com/flutter/buildroot/pull/77.
3 years, 5 months ago (2017-06-29 00:11:07 UTC) #3
zra
Please also remove the definition of the flag in tools/gn.py
3 years, 5 months ago (2017-06-29 15:04:26 UTC) #4
aam
On 2017/06/29 15:04:26, zra wrote: > Please also remove the definition of the flag in ...
3 years, 5 months ago (2017-06-29 16:52:13 UTC) #5
rmacnak
lgtm
3 years, 5 months ago (2017-06-29 19:16:56 UTC) #6
aam
3 years, 5 months ago (2017-06-29 20:18:51 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
501688de4cb6ba62a5bfe655361edf122cc1d7fc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698