tools/gn.py - Issue 2963053002: Drop custom dart_host_sdk used for Flutter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn.py

Issue 2963053002: Drop custom dart_host_sdk used for Flutter. (Closed)

Patch Set: Merge branch 'master' of github.com:dart-lang/sdk into drop_custom_dart_host_pub Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn.py

diff --git a/tools/gn.py b/tools/gn.py

index 54e48e9bd2ff2df9995f7711f2ab9def7c8aba76..9b7fe2f96d5a9fdbdbbdd52604bb2a4c6dbfc8bd 100755

--- a/tools/gn.py

+++ b/tools/gn.py

@@ -147,11 +147,6 @@ def ToGnArgs(args, mode, arch, target_os):

gn_args['host_cpu'] = HostCpuForArch(arch)

crossbuild = gn_args['target_cpu'] != gn_args['host_cpu']

- # See: runtime/observatory/BUILD.gn.

- # This allows the standalone build of the observatory to fall back on

- # dart_bootstrap if the prebuilt SDK doesn't work.

- gn_args['dart_host_pub_exe'] = ""

if arch != HostCpuForArch(arch):

# Training an app-jit snapshot under a simulator is slow. Use script

# snapshots instead.

« no previous file with comments | « runtime/observatory/BUILD.gn ('k') | no next file » | no next file with comments »