Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2962963003: [Cronet] Replace use of cronet_licenses.py with licenses.py (Closed)

Created:
3 years, 5 months ago by mef
Modified:
3 years, 5 months ago
Reviewers:
kapishnikov
CC:
chromium-reviews, cbentzel+watch_chromium.org, ios-reviews_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Replace use of cronet_licenses.py with licenses.py BUG=710801 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2962963003 Cr-Commit-Position: refs/heads/master@{#483385} Committed: https://chromium.googlesource.com/chromium/src/+/997021610f0a7631e4887e999aaacbc9cacbbce8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M components/cronet/ios/BUILD.gn View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
mef
PTAL. The LICENSE file gets "mt19937ar" because dependencies changed from //net to //components/cronet/ios:cronet_framework.
3 years, 5 months ago (2017-06-28 22:01:40 UTC) #3
kapishnikov
lgtm
3 years, 5 months ago (2017-06-28 22:09:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2962963003/1
3 years, 5 months ago (2017-06-29 15:55:44 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-06-29 16:45:36 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/997021610f0a7631e4887e999aaa...

Powered by Google App Engine
This is Rietveld 408576698