Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2962893002: Add a JUnit test rule for clearing app data prior to testing. (Closed)

Created:
3 years, 5 months ago by troyhildebrandt
Modified:
3 years, 5 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a JUnit test rule for clearing app data prior to testing. Having a test rule for clearing app data allows us to use RuleChain to ensure we clear app data before initializing the browser process. Currently, many chrome/browser tests that use ApplicationData.clearAppData are flaky because of a race condition between clearing app data and initializing the browser. BUG=737610 Review-Url: https://codereview.chromium.org/2962893002 Cr-Commit-Position: refs/heads/master@{#483136} Committed: https://chromium.googlesource.com/chromium/src/+/054a0dccede86d525f94d516285e79adde6fe6f1

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M chrome/android/java_sources.gni View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/android/javatests/src/org/chromium/chrome/browser/test/ClearAppDataTestRule.java View 1 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
troyhildebrandt
3 years, 5 months ago (2017-06-28 16:55:05 UTC) #3
Ted C
lgtm
3 years, 5 months ago (2017-06-28 17:07:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2962893002/20001
3 years, 5 months ago (2017-06-28 17:09:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/478203)
3 years, 5 months ago (2017-06-28 18:37:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2962893002/20001
3 years, 5 months ago (2017-06-28 18:48:42 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 21:02:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/054a0dccede86d525f94d516285e...

Powered by Google App Engine
This is Rietveld 408576698