Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2962853002: [turbofan] Add toLowerCase, toUpperCase operators to the infamous escape analysis list. (Closed)

Created:
3 years, 5 months ago by Jarin
Modified:
3 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add toLowerCase, toUpperCase operators to the infamous escape analysis list. BUG=chromium:733181 Review-Url: https://codereview.chromium.org/2962853002 Cr-Commit-Position: refs/heads/master@{#46279} Committed: https://chromium.googlesource.com/v8/v8/+/e14c4c95922f9b54d107cba55d39ac7562f114a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M src/compiler/escape-analysis.cc View 1 chunk +2 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/regress-733181.js View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Jarin
Could you take a look, please?
3 years, 5 months ago (2017-06-28 10:45:51 UTC) #4
Benedikt Meurer
lgtm
3 years, 5 months ago (2017-06-28 10:46:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2962853002/1
3 years, 5 months ago (2017-06-28 11:05:52 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 11:12:32 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/e14c4c95922f9b54d107cba55d39ac7562f...

Powered by Google App Engine
This is Rietveld 408576698